Skip to content

Commit

Permalink
lib: fix NULL->field_len access
Browse files Browse the repository at this point in the history
Currenlty, this function is used only by:
  - unit test of csv.c (see its main() section)
  - ptm_lib.c

In case of ptm, it is safe to return NULL because:
  csv_encode_record() -> return NULL
     _ptm_lib_encode_header() -> return NULL
        the only consumer of the return value is: ptm_lib_init_msg()
        that checks the NULL return.

Warning:
  Access to field 'field_len' results in a dereference of a null
  pointer (loaded from variable 'fld')

Signed-off-by: Vincent Jardin <vincent.jardin@6wind.com>
  • Loading branch information
Vincent JARDIN committed Oct 9, 2017
1 parent 3f58e1b commit 43b798b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/csv.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,8 @@ csv_record_t *csv_encode_record(csv_t *csv, csv_record_t *rec, int count, ...)

va_start(list, count);
str = csv_field_iter(rec, &fld);
if (!fld)
return NULL;
for (tempc = 0; tempc < count; tempc++) {
col = va_arg(list, char *);
for (i = 0; i < fld->field_len; i++) {
Expand Down

0 comments on commit 43b798b

Please sign in to comment.