Skip to content

Commit

Permalink
OSPF ANVL failures in 3.0
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by:   Donald Sharp <sharpd@cumulusnetworks.com>

Ticket: CM-10088

When we pulled this patch from upstream there was one spot where we
incorrectly used min_ls_interval (5s) instead of min_ls_arrival (1s).
commit ac7424f
Author: Michael Rossberg <michael.rossberg@tu-ilmenau.de>
Date:   Mon Jul 27 21:05:44 2015 +0200

    configuration options for faster OSPF convergence

    Allow configuration of faster OSPF convergence via the
    min_ls_interval and min_ls_arrival timer lengths.

    This patch was originated by Michael, and cross-ported
    to Cumulus's Quagga.
  • Loading branch information
Daniel Walton committed May 14, 2016
1 parent 3ff8613 commit 3dfc79c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ospfd/ospf_flood.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ ospf_flood (struct ospf *ospf, struct ospf_neighbor *nbr,
; /* Accept this LSA for quick LSDB resynchronization. */
}
else if (tv_cmp (tv_sub (recent_relative_time (), current->tv_recv),
intms2tv (ospf->min_ls_interval)) < 0)
intms2tv (ospf->min_ls_arrival)) < 0)
{
if (IS_DEBUG_OSPF_EVENT)
zlog_debug ("LSA[Flooding]: LSA is received recently.");
Expand Down
4 changes: 2 additions & 2 deletions ospfd/ospf_zebra.c
Original file line number Diff line number Diff line change
Expand Up @@ -1264,8 +1264,8 @@ ospf_distribute_list_update (struct ospf *ospf, uintptr_t type,

/* Set timer. */
ospf->t_distribute_update =
thread_add_timer (master, ospf_distribute_list_update_timer,
(void *) type, ospf->min_ls_interval);
thread_add_timer_msec (master, ospf_distribute_list_update_timer,
(void *) type, ospf->min_ls_interval);
}

/* If access-list is updated, apply some check. */
Expand Down

0 comments on commit 3dfc79c

Please sign in to comment.