nhrpd: Fix multicast crash due to dangling references to nhrp peers

Signed-off-by: Reuben Dowle <reuben.dowle@4rf.com>
LabNConsulting · Apr 5, 2021 · 0da7701 · 0da7701
1 parent fa31fcf
commit 0da7701
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/nhrpd/nhrp_multicast.c b/nhrpd/nhrp_multicast.c
@@ -62,8 +62,8 @@ static void nhrp_multicast_forward_nbma(union sockunion *nbma_addr, struct inter
 	if(p && p->online) {
 		/* Send packet */
 		nhrp_multicast_send(p, pkt);
-		nhrp_peer_unref(p);
 	}
+	nhrp_peer_unref(p);
 }
 
 static void nhrp_multicast_forward_cache(struct nhrp_cache *c, void *pctx)