Fix data region column name references #2526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary logging parameters from CustomizeViewHelper Update CustomizeViewHelper to use FieldKey
|
ERROR: A pull request from |
This was referenced Jun 30, 2025
labkey-danield
approved these changes
Jul 1, 2025
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Several of the changes I'm taking at face value. If the test passes on TeamCity then I'm assuming it is good.
| * @return The data-recordid property of the <tr> element for the specified field in the "Available Fields" column tree. | ||
| */ | ||
| private WebElement expandPivots(String[] fieldKeyParts) | ||
| private WebElement expandPivots(CharSequence fieldIdentifier) |
Contributor
There was a problem hiding this comment.
nit:
Maybe update the javadoc comment for the method to reference fieldIdentifier and not fieldKeyParts.
labkey-chrisj
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
My previous DataRegionTable refactor attempted to recreate the previous behavior that would remove spaces when matching field labels. I covered the case where the test passed in an unnecessary space but not when they omitted a space. Rather that duplicating that particular behavior, this updates the handful of tests that are passing incorrect field labels.
I've also updated the
CustomizeViewhelper to acceptFieldKeyobjects instead of String arrays.Related Pull Requests
Changes