Publish Libraries to deploy into Tomcat #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
commented
May 11, 2021
server/build.gradle
Outdated
| @@ -154,10 +162,25 @@ project.publishing { | |||
| } | |||
| } | |||
|
|
|||
| tomcatJars(MavenPublication) { | |||
| groupId = 'org.labkey.api' | |||
There was a problem hiding this comment.
Not sure what the appropriate group is. I also considered org.labkey and org.labkey.build.
There was a problem hiding this comment.
I think org.labkey.build makes sense.
labkey-susanh
approved these changes
May 11, 2021
server/build.gradle
Outdated
| @@ -154,10 +162,25 @@ project.publishing { | |||
| } | |||
| } | |||
|
|
|||
| tomcatJars(MavenPublication) { | |||
| groupId = 'org.labkey.api' | |||
There was a problem hiding this comment.
I think org.labkey.build makes sense.
server/build.gradle
Outdated
| @@ -33,6 +33,14 @@ dependencies | |||
| xsdDoc "docflex:docflex-xml-re:${docflexXmlReVersion}" | |||
| } | |||
|
|
|||
| project.tasks.register("tomcatLibsZip", Zip) { | |||
| Zip zip -> | |||
| zip.group = "Build" | |||
There was a problem hiding this comment.
Could use GroupNames.BUILD here instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
LabKey distributions include several jars that get deployed to
$CATALINA_HOME/lib. The gradle plugin currently pulls these jars from thetomcatJarsconfiguration of the server project. This new task (:server:tomcatLibsZip) allows a standalone module build to pull compatible libraries from Artifactory to produce a distribution.Related Pull Requests
Changes
:server:tomcatLibsZiptask and publish its output to Artifactory