Skip to content

Issue 45345: Optimize default DB connection pool config #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

Reviewing performance data, we're spending a surprising amount of time validating DB connections before using them.

Changes

  • Switch from validating DB connections when borrowing from the pool to idle times
  • Be more prescriptive for the desired size of the pool - initial and idle

@labkey-stuartm
Copy link

#https://github.com/LabKey/syseng-chef-server/pull/400
Mirror changes in chef lk_appserver cookbook

@labkey-adam
Copy link
Contributor

Are the [FATAL: database "bt3" does not exist] bootstrap errors related to your changes?

@labkey-jeckels
Copy link
Contributor Author

@labkey-adam yes, turns out that specifying an initialSize causes the connection pool to throw a SQLException when initializing due to the lack of a DB, breaking bootstrapping. I've backed out that part of the change, which was less important than the other edits.

@labkey-jeckels labkey-jeckels merged commit 4c0f46f into develop Aug 24, 2022
@labkey-jeckels labkey-jeckels deleted the fb_45345_connectionPool branch August 24, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants