Issue 53616: Assay creation attempt after an error results in error #6954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bout existing assay
labkey-adam
approved these changes
Aug 21, 2025
cnathe
approved these changes
Aug 22, 2025
|
Test has now passed, including the long-commented out coverage (which I don't think actually covers the problem in the original issue, but is fine coverage to have regardless). I'd appreciate a quick review of the test updates next week before merging. |
labkey-tchad
approved these changes
Aug 25, 2025
labkey-danield
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We're not using a transaction-aware cache, so we're ending up caching an assay design that didn't actually get committed to the DB because the attempt failed.
Changes
DatabaseCacheTasks 📍