Issue 49544: Deprecate the ability to select specific objects to import and apply import to multiple folders under the advanced import options #6419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-klum
requested changes
Mar 6, 2025
Contributor
labkey-klum
left a comment
labkey-klum
left a comment
There was a problem hiding this comment.
These changes look good but there is also the check box for advanced options that is available from the folder settings import tab that should be put behind the flag:
Contributor
Author
|
Hi @labkey-klum - The reason I did not put that checkbox behind the flag since checking it displays below page, where there are two more options here 'Validate Queries' and 'Study Import Options' - should those be put behind the flag as well? Also, Validate Queries seems redundant here, since its already present in the previous step.
|
…s_depcrecate_flag
…visits', with tooltips on ImportFolder page.
…s_depcrecate_flag
…recated flag as well. Add deprecated message view. Some updates on failForUndefinedVisits option.
cnathe
requested changes
Mar 19, 2025
…s_depcrecate_flag
…ddition of Deprecated Message view.
labkey-klum
reviewed
Mar 21, 2025
labkey-klum
approved these changes
Mar 21, 2025
…er Import (via Process and Import Data > select folder zip > Import Data > Import Folder)
…Renderable as an argument, use DOM builder to generate server side HTML to ensure proper encoding. Also, keep 'Fail import of undefined visits' as-is when importing from a Pipeline route.
…s_depcrecate_flag
labkey-adam
requested changes
Mar 22, 2025
Contributor
labkey-adam
left a comment
labkey-adam
left a comment
There was a problem hiding this comment.
See comments about not adding a JspBase method and not double encoding the help text
…() variants that take HtmlString to take Renderable instead.
labkey-adam
approved these changes
Mar 24, 2025
cnathe
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 49544: Deprecate the ability to select specific objects to import and apply import to multiple folders under the advanced import options
Keep 'Advanced Import Options' behind deprecated flag until 25.7, then we will remove it. I had already opened a PR where I had removed this option, can use it for reference.
Related Pull Requests
Changes