Skip expensive work in getQueries.api if certain props aren't needed #3961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…title aren't needed
…parameters on linked schema page.
labkey-adam
requested review from
labkey-nicka
and removed request for
labkey-nicka
labkey-jeckels
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
As discussed in the related PR and ticket, generating the column list for PIVOT queries can be very expensive. Related PR avoided this work in some cases (e.g., schema browser tree). This PR adds flags and reworks
GetQueriesActionto avoid querying for columns in other cases (e.g., linked schema table drop-down).https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=47010
Related Pull Requests
Changes
includeColumnsandincludeTitle. If these two flags arefalseas well as the (existing)includeColumnsflag, then avoid creating the TableInfo and invoking getPivotValues().