Skip to content

Issue 46962: Fix problems with project paths #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 20, 2022
Merged

Issue 46962: Fix problems with project paths #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8b05c93
Remove premature return from renderLabel
labkey-susanh Dec 16, 2022
03acfd5
Set maxLength on project name input field
labkey-susanh Dec 16, 2022
31bb18d
release notes and versions and stuff
labkey-susanh Dec 16, 2022
cb47ce3
@labkey/components version update
labkey-susanh Dec 16, 2022
420d9a2
Fix lock file
labkey-susanh Dec 16, 2022
7550d2e
Merge remote-tracking branch 'origin/develop' into fb_projectNameEnco…
labkey-susanh Dec 19, 2022
44d226b
v2.273.1-projectNameEncoding.1
labkey-susanh Dec 19, 2022
d9793fb
update labkey-api-js
labkey-susanh Dec 19, 2022
8d23eec
v2.273.1-projectNameEncoding.2
labkey-susanh Dec 19, 2022
9d92bf0
@labkey/api release version
labkey-susanh Dec 19, 2022
54facf7
v2.273.1
labkey-susanh Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "2.273.0",
"version": "2.273.1",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down Expand Up @@ -52,7 +52,7 @@
},
"homepage": "https://github.com/LabKey/labkey-ui-components#readme",
"dependencies": {
"@labkey/api": "~1.17.0",
"@labkey/api": "1.17.1",
"bootstrap": "~3.4.1",
"classnames": "~2.3.2",
"enzyme": "~3.11.0",
Expand Down
5 changes: 5 additions & 0 deletions packages/components/releaseNotes/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# @labkey/components
Components, models, actions, and utility functions for LabKey applications and pages.

### version 2.273.1
*Released*: 19 December 2022
* Remove premature return from renderLabel in TextInput
* Set maxLength property on ProjectProperties name field

### version 2.273.0
*Released*: 15 December 2022
* Update FM UI to use "Storage" instead of "Freezer"
Expand Down
3 changes: 3 additions & 0 deletions packages/components/src/internal/components/administration/ProjectProperties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ interface Props {
onChange?: () => void;
}

const MAX_FOLDER_NAME_LENGTH = 255;

export const ProjectProperties: FC<Props> = memo(props => {
const { autoFocus, defaultTitle, defaultName, onChange } = props;
const [name, setName] = useState<string>(defaultName);
Expand Down Expand Up @@ -47,6 +49,7 @@ export const ProjectProperties: FC<Props> = memo(props => {
onChange={onNameChange}
required
type="text"
maxLength={MAX_FOLDER_NAME_LENGTH}
/>
<span className="help-block">
<label className="checkbox-inline" title={toggleLabel}>
Expand Down
2 changes: 0 additions & 2 deletions packages/components/src/internal/components/forms/input/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ export class TextInput extends DisableableInput<TextInputProps, TextInputState>
const { label, queryColumn, showLabel, allowDisable, addLabelAsterisk, renderFieldLabel } = this.props;
const { isDisabled } = this.state;

if (!showLabel)
return null;

if (renderFieldLabel) {
return renderFieldLabel(queryColumn);
Expand Down
8 changes: 4 additions & 4 deletions packages/components/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,10 +1490,10 @@
"@jridgewell/resolve-uri" "3.1.0"
"@jridgewell/sourcemap-codec" "1.4.14"

"@labkey/api@~1.17.0":
version "1.17.0"
resolved "https://labkey.jfrog.io/artifactory/api/npm/libs-client/@labkey/api/-/@labkey/api-1.17.0.tgz#3100ce360e93595b3fcce8968ab25224a6320cf3"
integrity sha512-RJ/8+1DF4zdCI+QwIHtKqz0ZTfm3Kk4QcWu6k9cDPlzB77MBzRaKQ+y6Co2xrnH7hE/UDcn0h1AarOJIRx99Pg==
"@labkey/api@1.17.1":
version "1.17.1"
resolved "https://labkey.jfrog.io/artifactory/api/npm/libs-client/@labkey/api/-/@labkey/api-1.17.1.tgz#669bc03abe94fe832a4e6fd8adb13144536ab092"
integrity sha512-WkHwxiLtaTw/G5puYpHHr+kNLUQLEa+d8rA46kMU6GGHv1yjDwLQdmzJHKWRLTsJdpTSZ+ODMQkJG4T/B/JInA==

"@labkey/build@6.5.0":
version "6.5.0"
Expand Down