33287: Support domain APIs #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support for drop, get
- support for create, save - complete modeling of ConditionalFormat, Domain, PropertyDescriptor, and PropertyValidator - all models serialize/deserialize json
- "python test/test_security.py"
- add typings for public experiment methods
labkey-klum
reviewed
May 8, 2018
| # Create a list domain | ||
| ################### | ||
| list_domain_definition = { | ||
| 'kind': 'IntList', # or 'VarList' |
There was a problem hiding this comment.
Should we have a page on .org at the API level which documents all of the domains which can be created with this api and what the domain kind optional params are.
There was a problem hiding this comment.
Yes, we should also have API tests (in java?) for all the ones that we state we support.
There was a problem hiding this comment.
Even better would be an API endpoint that would describe to users the available types and the associated optional parameters.
labkey-klum
approved these changes
May 8, 2018
cnathe
approved these changes
May 8, 2018
|
Nick and I met last week to discuss this and he gave me a tour of the changes in this pull request at that time. I agree that it will be a good reference as we do the work for the Rlabkey package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.