Skip to content

Issue 47044: Decode plus sign that may be a part of a folder path #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 1.18.1 - 2023-01-09
- [Issue 47044](https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=47044): Decode the plus sign that may be part of a folder path

## 1.18.0 - 2023-01-03
- [Issue 47010](https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=47010): Add `includeViewDataUrl` and `includeTitle` parameters to `Query.getQueries()`. Setting these to `false` (along with existing parameter `includeColumns`) can improve performance of getQueries() calls.

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/api",
"version": "1.18.0",
"version": "1.18.1",
"description": "JavaScript client API for LabKey Server",
"scripts": {
"build": "npm run build:dist && npm run build:docs",
Expand Down
1 change: 1 addition & 0 deletions src/labkey/ActionURL.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ describe('ActionURL', () => {
validatePath('/home/project-begin.view', '', '/home', 'project', 'begin');
validatePath('/home/with/folder/project-begin.view', '', '/home/with/folder', 'project', 'begin');
validatePath('/%E2%98%83/%E2%9D%86/%E2%A8%8Drosty-%F0%9D%95%8Anow.view', '', '/☃/❆', '⨍rosty', '𝕊now');
validatePath('/home%2C%2B%2B%3B%40%26%3D%24%23%2Cfolder/project-begin.view', '', '/home,++;@&=$#,folder', 'project', 'begin');
validatePath(
'/my%20folder/my%20path/pipeline-status-action.view?rowId=123',
'',
Expand Down
1 change: 1 addition & 0 deletions src/labkey/ActionURL.ts
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ function fullyDecodeURIPath(path: string): string
{
return decodeURI(path)
.replace(/%2C/g, ",")
.replace(/%2B/g, "+")
.replace(/%3B/g, ";")
.replace(/%40/g, "@")
.replace(/%26/g, "&")
Expand Down