-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor labkey-api-java repository #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@labkey-tchad I think I'll need your help to get the Java Remote API suite to run after this refactor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better or for worse, we currently publish this under org.labkey.api/labkey-client-api This will no longer be the case by default with this move. We'll need to either update the repository name to be labkey-client-api or change the name in build.gradle file.
gradle.properties
Outdated
@@ -7,14 +7,14 @@ artifactory_contextUrl=https://labkey.jfrog.io/artifactory | |||
sourceCompatibility=17 | |||
targetCompatibility=17 | |||
|
|||
gradlePluginsVersion=1.36.1 | |||
gradlePluginsVersion=1.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to need a new gradle plugin release for this change. We have a method there called getRemoteApiProjectPath
that is used for declaring dependencies in various places
Whatever the name we chose, we can't rely on the repository name to define it. TeamCity uses some internal logic to name the root directory for builds. This causes gradle to produce some real nonsense names: @labkey-adam The solution is to define the name in
|
@labkey-tchad of course, 77414112b699049a... not sure why I couldn't find my artifact. :) https://labkey.jfrog.io/ui/packages/gav:%2F%2Forg.labkey.api:77414112b699049a?name=77414112b699049a&type=packages |
Rationale
The extra
labkey-client-api
folder in this repository is unnecessary, left over from when the repo used to houselabkey-api-sas
as well.Related Pull Requests
Changes