Skip to content

Refactor labkey-api-java repository #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Refactor labkey-api-java repository #45

merged 5 commits into from
Jan 11, 2023

Conversation

labkey-adam
Copy link
Contributor

Rationale

The extra labkey-client-api folder in this repository is unnecessary, left over from when the repo used to house labkey-api-sas as well.

Related Pull Requests

Changes

  • Eliminate unnecessary intermediate folder

@labkey-adam
Copy link
Contributor Author

@labkey-tchad I think I'll need your help to get the Java Remote API suite to run after this refactor

Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better or for worse, we currently publish this under org.labkey.api/labkey-client-api This will no longer be the case by default with this move. We'll need to either update the repository name to be labkey-client-api or change the name in build.gradle file.

@@ -7,14 +7,14 @@ artifactory_contextUrl=https://labkey.jfrog.io/artifactory
sourceCompatibility=17
targetCompatibility=17

gradlePluginsVersion=1.36.1
gradlePluginsVersion=1.38.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need a new gradle plugin release for this change. We have a method there called getRemoteApiProjectPath that is used for declaring dependencies in various places

@labkey-tchad
Copy link
Member

For better or for worse, we currently publish this under org.labkey.api/labkey-client-api This will no longer be the case by default with this move. We'll need to either update the repository name to be labkey-client-api or change the name in build.gradle file.

Whatever the name we chose, we can't rely on the repository name to define it. TeamCity uses some internal logic to name the root directory for builds. This causes gradle to produce some real nonsense names:
image

@labkey-adam The solution is to define the name in settings.gradle

rootProject.name='labkey-client-api' # or 'labkey-api-java'

@labkey-adam
Copy link
Contributor Author

@labkey-tchad of course, 77414112b699049a... not sure why I couldn't find my artifact. :) https://labkey.jfrog.io/ui/packages/gav:%2F%2Forg.labkey.api:77414112b699049a?name=77414112b699049a&type=packages

@labkey-adam labkey-adam merged commit 34e83c7 into develop Jan 11, 2023
@labkey-adam labkey-adam deleted the fb_refactor branch January 11, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants