Skip to content

Clean up base Command and CommandResponse APIs #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 26, 2022
Merged

Clean up base Command and CommandResponse APIs #41

merged 7 commits into from
Oct 26, 2022

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Oct 24, 2022 •
edited
Loading

Rationale

Started some code cleanup against a feature branch. Re-targeting to develop.

Related Pull Requests

Changes

  • Remove Command.copy and unnecessary copy constructors
  • Make Response constructors more consistent
  • Make ResponseObject properties immutable
  • Remove long unused org.labkey.remoteapi.security.ACL
  • Chip away at missing JavaDoc

@labkey-tchad labkey-tchad mentioned this pull request Oct 24, 2022
Closed
labkey-adam
labkey-adam requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please summarize these changes in CHANGELOG.md

Note that this still builds with 100+ JavaDoc warnings, but perhaps that's for another day...

@labkey-tchad labkey-tchad marked this pull request as draft October 24, 2022 23:22
@labkey-tchad labkey-tchad changed the title Add documentation and remove unused patterns Clean up base Command and CommandResponse APIs Oct 24, 2022
labkey-adam
labkey-adam reviewed Oct 25, 2022
View reviewed changes
@labkey-tchad labkey-tchad mentioned this pull request Oct 25, 2022
Merged
@labkey-tchad labkey-tchad marked this pull request as ready for review October 26, 2022 16:19
labkey-adam
labkey-adam requested changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@labkey-adam labkey-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tweaks requested so we're prepped for publishing today and next round of development

@labkey-tchad labkey-tchad merged commit 4dc2b2d into develop Oct 26, 2022
@labkey-tchad labkey-tchad deleted the fb_codeCleanup branch October 26, 2022 17:41
@labkey-tchad labkey-tchad mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-adam labkey-adam labkey-adam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-adam