Skip to content

Fix NPE when saving assay protocol with transform scripts #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2022
Merged

Fix NPE when saving assay protocol with transform scripts #27

merged 2 commits into from
Jul 5, 2022

Conversation

labkey-tchad
Copy link
Member

Rationale

Trying to refactor a test to create an assay via API. The assay has a transform script, which caused an NPE when attempting to construct the response object.

java.lang.NullPointerException: Cannot invoke "java.util.List.add(Object)" because "this._protocolTransformScripts" is null
	at org.labkey.remoteapi.assay.Protocol.<init>(Protocol.java:114)
	at org.labkey.remoteapi.assay.ProtocolResponse.<init>(ProtocolResponse.java:13)
	at org.labkey.remoteapi.assay.SaveProtocolCommand.createResponse(SaveProtocolCommand.java:19)
	at org.labkey.remoteapi.assay.SaveProtocolCommand.createResponse(SaveProtocolCommand.java:6)
	at org.labkey.remoteapi.Command.execute(Command.java:232)

Related Pull Requests

Changes

  • Fix NPE in Protocol constructor

@labkey-tchad labkey-tchad merged commit ce3d889 into develop Jul 5, 2022
@labkey-tchad labkey-tchad deleted the fb_assayXarExportTest branch July 5, 2022 17:21
@labkey-tchad labkey-tchad mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-chrisj labkey-chrisj labkey-chrisj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-chrisj