Skip to content

Commit d804c03

Browse files
Revert "Declare api and implementation dependencies to align with code usages (#11)" (#12)
This reverts commit 1a917f6.
1 parent 1a917f6 commit d804c03

File tree

5 files changed

+4
-13
lines changed

5 files changed

+4
-13
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

labkey-client-api/CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* Fix pre-population of session ID and CSRF token in Connection
77
* Identify target server with a `URI` instead of a `String`
88
* Add support for Log4J 2
9-
* Add some missing dependency declarations
109

1110
## version 1.3.0
1211
*Released* : 16 June 2020

labkey-client-api/build.gradle

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,17 +63,13 @@ group "org.labkey.api"
6363
version "1.3.1-SNAPSHOT"
6464

6565
dependencies {
66-
implementation "org.apache.httpcomponents:httpmime:${httpmimeVersion}"
66+
api "org.apache.httpcomponents:httpmime:${httpmimeVersion}"
6767
api ("com.googlecode.json-simple:json-simple:${jsonSimpleVersion}")
6868
{
6969
// exclude this because it gets in the way of our own JSON object implementations from server/api
7070
exclude group: "org.json", module:"json"
7171
}
72-
implementation "net.sf.opencsv:opencsv:${opencsvVersion}"
73-
implementation "commons-logging:commons-logging:${commonsLoggingVersion}"
74-
api "org.apache.httpcomponents:httpclient:${httpclientVersion}"
75-
implementation "commons-codec:commons-codec:${commonsCodecVersion}"
76-
api "org.apache.httpcomponents:httpcore:${httpcoreVersion}"
72+
api "net.sf.opencsv:opencsv:${opencsvVersion}"
7773
}
7874

7975
jar {

labkey-client-api/gradle.properties

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,8 @@ artifactoryPluginVersion=4.13.0
1414
bintrayPluginVersion=1.8.4
1515
gradlePluginsVersion=1.12.0
1616

17-
commonsCodecVersion=1.10
18-
commonsLoggingVersion=1.2
1917
fluentHcVersion=4.3.5
2018

21-
httpclientVersion=4.5.3
22-
httpcoreVersion=4.4.6
2319
httpmimeVersion=4.5.3
2420

2521
jsonSimpleVersion=1.1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)