Skip to content

Commit 1a917f6

Browse files
Declare api and implementation dependencies to align with code usages (#11)
1 parent d2b23d1 commit 1a917f6

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

labkey-client-api/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Fix pre-population of session ID and CSRF token in Connection
77
* Identify target server with a `URI` instead of a `String`
88
* Add support for Log4J 2
9+
* Add some missing dependency declarations
910

1011
## version 1.3.0
1112
*Released* : 16 June 2020

labkey-client-api/build.gradle

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,17 @@ group "org.labkey.api"
6363
version "1.3.1-SNAPSHOT"
6464

6565
dependencies {
66-
api "org.apache.httpcomponents:httpmime:${httpmimeVersion}"
66+
implementation "org.apache.httpcomponents:httpmime:${httpmimeVersion}"
6767
api ("com.googlecode.json-simple:json-simple:${jsonSimpleVersion}")
6868
{
6969
// exclude this because it gets in the way of our own JSON object implementations from server/api
7070
exclude group: "org.json", module:"json"
7171
}
72-
api "net.sf.opencsv:opencsv:${opencsvVersion}"
72+
implementation "net.sf.opencsv:opencsv:${opencsvVersion}"
73+
implementation "commons-logging:commons-logging:${commonsLoggingVersion}"
74+
api "org.apache.httpcomponents:httpclient:${httpclientVersion}"
75+
implementation "commons-codec:commons-codec:${commonsCodecVersion}"
76+
api "org.apache.httpcomponents:httpcore:${httpcoreVersion}"
7377
}
7478

7579
jar {

labkey-client-api/gradle.properties

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@ artifactoryPluginVersion=4.13.0
1414
bintrayPluginVersion=1.8.4
1515
gradlePluginsVersion=1.12.0
1616

17+
commonsCodecVersion=1.10
18+
commonsLoggingVersion=1.2
1719
fluentHcVersion=4.3.5
1820

21+
httpclientVersion=4.5.3
22+
httpcoreVersion=4.4.6
1923
httpmimeVersion=4.5.3
2024

2125
jsonSimpleVersion=1.1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.6.1-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)