Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* ERC20Allocator, RateLimitedV2, erc20 holding pcv deposit * fix unit tests * 2xlarge container to fix failing tests * lower fuzz runs to reduce memory used * 2xlarge resource group * add additional tests for erc20 allocator, add new min check on buffer for dripping * beef up unit tests, test non whitelisted psms, doAction, edit, delete, deposit, check drip condition, add check effects interaction comments in allocator * fuzz test getAdjustedAmount * buffer exhaustion causes dripaction to not be allowed * add test that sets buffer to 0, which means all condition checks are false * remove unused _resetBuffer function in RateLimitedV2 * Add tests for RateLimitedV2, mock RateLimitedV2, event for replenishing buffer, fuzz tests for RateLimitedV2 * add fuzz test to both deplete and replenish the buffer * add comment to rate limited v2 explaining why SSTORE can be saved when already at buffer cap * VIP-10 solidity and calldata for timelock * fix bug where drip condition can be true even if pcv deposit has no balance * increase test coverage for ERC20Allocator with 2 deposits, 1 with decimal normalization, one without, add setup tests * add more unit test assertions * refactor allocator to call getSkimDetails, add additional test assertions in decimal normalized unit tests * add additional assertions on decimals normalizer test * add additional assertions for getSkimDetails on skim logic in decimal normalizer test * remove log emit on no-op deposit, change comment from fei to volt * mainnet roles, integration tests for erc20 allocator * add skimming integration tests * remove pesky hardcoded hardhat mainnet block number, vip 10 in typescript and deploy * remove test looking for log in erc20holding deposit test * allocator connector feature and tests * refactor arch to remove default pcv deposit * fix fialing compound pcv deposit test * downsize circleci config to large * lock version pragma on ERC20HoldingPCVDeposit * lock version pragma on IERC20HoldingPCVDeposit * update comments for IERC20 allocator * simplified proposal creation to remove array assignments * remove address 0 checks, fix issue in check action allowed where buffer was being checked in isolation, rename from target to pcvDeposit, fix tests * add additional test assertions * update function and event naming * fix buffer scaling issue in get drip details function, add more comments and tests * fix test name, add additional assertions * remove return value in _depleteBuffer() * add unit tests where decimals are negative adjusted * fix typescript proposal * add example comment to get drip details * remove unnecessary drip and skim functions that allow passing the psm address, updated tests * update PSMUpdated event to remove token param * clean up ts DAO scripts * update comments in allocator, no code changes * change view only function in ERC20Allocator from public to external as it was not used inside the contract. Add additional tests to ERC20Allocator, remove console.log from RateLimitedV2 * update buffer cap to 300k, keep 500k per day rate limit per second, fix vip description in typescript * remove decimal normalizer setter in editPSM, rename editPSM, add to param in skim and drip events, fix tests, add more tests for RateLimitedV2 * fix rate limit buffer * remove comments from test * remove chain specific logic for ERC20HoldingPCVDeposit * add memo to pcv deposit to not use in production, and only use for testing as is * update names of local variables to be more accurate * remove check on granting pcv controller role being a whitelisted address in the guardian * add deployed ERC20 allocator address * fix bug in integration tests for calculating pcv pre and post proposal * vip 10 calldata generation matching * add additional doAction integration tests, add vip10 to erc20 allocator integration tests, add doLogging bool to pre and post timelock verification scripts * add assertions to vip10
- Loading branch information