Unit testing of non-core code

[krisgry]

Hi,
I would like to be able to add more tests to code I write in Tasks, typically code in cpp/hpp files I include in the Task.cpp. How?

Currently, the programs/tests framework only links against dune core, not the tasks. Is there a reason for this, or would you be willing to accept a PR on the matter?

Something like changing

dune/CMakeLists.txt

Lines 452 to 460 in d6da27e

	macro(dune_test source)
	get_filename_component(executable ${source} NAME_WE)
	add_executable(${executable} ${source})
	set_target_properties(${executable} PROPERTIES COMPILE_FLAGS
	"${DUNE_CXX_FLAGS}")
	target_link_libraries(${executable} dune-core ${DUNE_SYS_LIBS}
	${DUNE_VENDOR_LIBS})
	ADD_TEST(${executable} ${executable})
	endmacro(dune_test source)

to

  # Collect all task libraries for comprehensive test linking
  macro(dune_test source)
    get_filename_component(executable ${source} NAME_WE)
    add_executable(${executable} ${source})
    set_target_properties(${executable} PROPERTIES COMPILE_FLAGS
      "${DUNE_CXX_FLAGS}")
    add_dependencies(${executable} ${DUNE_STATIC_TASKS})
    target_link_libraries(${executable} dune-core ${DUNE_STATIC_TASKS}
      ${DUNE_SYS_LIBS} ${DUNE_VENDOR_LIBS})
    ADD_TEST(${executable} ${executable})
  endmacro(dune_test source)

This also opens another question: should the task-level unit tests still be placed in programs/tests, or does it make more sense to put them in the task folder, along with Task.cpp and Task.cmake? (this of course requires further modification of CMakeLists.txt)

[Bernardo-Gabriel]

Hi @krisgry, thank you for your time. I don't have a definitive answer about this yet. But we are looking into it.

[luis109]

Hi @krisgry

Apologies for the delay, and thank you for taking the time to look into this.

I don’t believe there’s a specific reason for linking only the Dune core. Your idea makes sense and could be useful for other developers as well.

Unfortunately, we’re a bit swamped at the moment and aren’t able to implement it ourselves. However, if you decide to go ahead with the implementation, we’d be happy to take a look! I don’t anticipate any major issues, especially since tests are an optional feature.

To answer your last question — yes, placing them in the task folder sounds like the best approach.

Thanks again!