Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/97/concat #98

Merged
merged 8 commits into from
May 28, 2024
Merged

Issue/97/concat #98

merged 8 commits into from
May 28, 2024

Conversation

eacharles
Copy link
Collaborator

Problem & Solution Description (including issue #)

The adds tools to do concatanation and slicing. These will be very useful from working with multiple files.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

sidneymau and others added 8 commits May 28, 2024 12:51
@sidneymau @eacharles
Initial commit for pyarrow support (#93)
dddf2af 
* Initial commit for pyarrow support

* fix up some unit test, not full coverage yet

* Cast arrow array to numpy array

* WIP, unit tests

* get unit test working

* Propagate metadata to pyarrow tables

* tweak for full coverage

---------

Co-authored-by: Eric Charles <echarles@gmail.com>
@eacharles
added mergeUtils.py
18cad3d
@eacharles
switch to using cli
8ab7b5b
@eacharles
added sliceUtils and get unit tests working
117693e
@eacharles
minor delinting
cc42f93
@eacharles
unit tests and cli coverage
6dba2cc
@eacharles
added test_cli
fe93d29
@eacharles
added click to environment.yml
087f863
ztq1996
ztq1996 approved these changes May 28, 2024
View reviewed changes
Copy link

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@eacharles eacharles merged commit 8f1677c into main May 28, 2024
6 checks passed
@eacharles eacharles deleted the issue/97/concat branch May 28, 2024 23:38
@eacharles eacharles mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztq1996 ztq1996 ztq1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eacharles @ztq1996 @sidneymau