Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD move to conda in CI job #58

Merged
merged 4 commits into from
Mar 24, 2023
Merged

PROD move to conda in CI job #58

merged 4 commits into from
Mar 24, 2023

Conversation

beckermr
Copy link
Contributor

This PR moves the CI job to conda. We could do more by making env files etc., but this is simple enough that it doesn't seem worth it.

@beckermr beckermr marked this pull request as ready for review March 24, 2023 15:07
@beckermr
Copy link
Contributor Author

@eacharles This is ready for review. The failure is from uploads to codecov which I don't understand but doesn't appear to be related.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ea3534) 100.00% compared to head (46ad067) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          605       605           
=========================================
  Hits           605       605           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt.

@beckermr
Copy link
Contributor Author

beckermr commented Mar 24, 2023

You'll have to merge here FWIW. I do not have write access.

@eacharles eacharles merged commit 049524c into LSSTDESC:main Mar 24, 2023
@beckermr beckermr deleted the conda4lyfe branch March 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants