-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic changes for nicer figures #185
Conversation
evevkovacs
commented
Sep 19, 2019
@yymao See test result for example of code with object catalog. Other issues should be fixed. |
@yymao Just caught your last comments. The commented line has been removed. I also removed the exception clause. I have already checked that the catalog has ra and dec so there is no reason for the call to get_sky_area to fail, and it is safe to remove the exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evevkovacs thanks! I would then suggest that we reorganize the logic a little bit for lines 152-165. In particular, checking ra/dec existence is more relevant for sky area, not for light cone. See my inline suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!