Implement Gaussian shifts #60
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #17 Implement Gaussian parameter shifts in the Smokescreen repository. * Add `draw_gaussian_param_shifts` function in `src/smokescreen/param_shifts.py` to handle Gaussian shifts. * Update `ConcealDataVector` class in `src/smokescreen/datavector.py` to support Gaussian shifts. * Add tests for Gaussian shifts in `tests/test_datavector.py`. * Update documentation in `docs/source/usage.rst` to include Gaussian shifts and example usage. * Add shift distribution option to main function in `src/smokescreen/__main__.py` and update CLI to accept `flat` or `gaussian` shift distribution. * Add `shift_distribution` keyword to example configuration files in `examples/cosmic_shear/blind_cosmic_shear_example.yaml` and `examples/supernovae/blind_sn_example.yaml`.
arthurmloureiro
added
enhancement
data-vector blinding
|
Needs further testing |
* Modify `test_load_shifts` and `test_calculate_concealing_factor_add` functions in `tests/test_datavector.py` to include Gaussian shifts. * Update `docs/source/usage.rst` to reflect the addition of Gaussian shifts. * Add `shift_distribution` keyword to `examples/supernovae/blind_sn_example.yaml` configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Implement Gaussian parameter shifts in the Smokescreen repository.
draw_gaussian_param_shiftsfunction insrc/smokescreen/param_shifts.pyto handle Gaussian shifts.ConcealDataVectorclass insrc/smokescreen/datavector.pyto support Gaussian shifts.tests/test_datavector.py.docs/source/usage.rstto include Gaussian shifts and example usage.src/smokescreen/__main__.pyand update CLI to acceptflatorgaussianshift distribution.shift_distributionkeyword to example configuration files inexamples/cosmic_shear/blind_cosmic_shear_example.yamlandexamples/supernovae/blind_sn_example.yaml.