Update to 1.21.11

[Artuto]

When using 1.21.11 the plugin throws errors like:

[15:05:57 ERROR]: Could not pass event CraftItemEvent to ImageFrame v1.8.7.0
java.lang.RuntimeException: No NMSWrapper implementation for UNSUPPORTED version UNSUPPORTED
        at ImageFrame-1.8.7.0.jar//com.loohp.imageframe.nms.NMS.getInstance(NMS.java:43) ~[?:?]
        at ImageFrame-1.8.7.0.jar//com.loohp.imageframe.listeners.Events.isCombinedMaps(Events.java:190) ~[?:?]
        at ImageFrame-1.8.7.0.jar//com.loohp.imageframe.listeners.Events.containsCombinedMaps(Events.java:177) ~[?:?]
        at ImageFrame-1.8.7.0.jar//com.loohp.imageframe.listeners.Events.containsCombinedMaps(Events.java:171) ~[?:?]
        at ImageFrame-1.8.7.0.jar//com.loohp.imageframe.listeners.Events.onClick(Events.java:93) ~[?:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[prismarine-api-1.21.11-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:71) ~[prismarine-api-1.21.11-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:630) ~[prismarine-api-1.21.11-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3269) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:59) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:14) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.network.PacketProcessor$ListenerAndPacket.handle(PacketProcessor.java:99) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.network.PacketProcessor.executeSinglePacket(PacketProcessor.java:33) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1500) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.server.MinecraftServer.recordTaskExecutionTimeWhileWaiting(MinecraftServer.java:1231) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1342) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:387) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.ClassNotFoundException: com.loohp.imageframe.nms.UNSUPPORTED
        at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:208) ~[prismarine-api-1.21.11-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:175) ~[prismarine-api-1.21.11-R0.1-SNAPSHOT.jar:?]
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?]
        at java.base/java.lang.Class.forName0(Native Method) ~[?:?]
        at java.base/java.lang.Class.forName(Class.java:534) ~[?:?]
        at java.base/java.lang.Class.forName(Class.java:513) ~[?:?]
        at io.papermc.reflectionrewriter.runtime.AbstractDefaultRulesReflectionProxy.forName(AbstractDefaultRulesReflectionProxy.java:68) ~[reflection-rewriter-runtime-0.0.3.jar:?]
        at io.papermc.paper.pluginremap.reflect.PaperReflectionHolder.forName(Unknown Source) ~[prismarine-1.21.11.jar:1.21.11-37-2141ac8]
        at ImageFrame-1.8.7.0.jar//com.loohp.imageframe.nms.NMS.getInstance(NMS.java:37) ~[?:?]
        ... 19 more

The plugin in general doesn't work either.

[LOOHP]

1.21.11 update is coming soon. Pending PaperMC/Paper#13388

[Artuto]

I think it should be considered to update the plugin to work on Paper servers with Mojang mappings, considering that the next version of the game will be fully unobfuscated.

[LOOHP]

Yes, however I want to wait until the next version before making any decisions because of the obfuscation chnages on the Minecraft source code.

[MiniDigger]

Hi, Mini from the PaperMC here,
spigot already signaled they will let plugins sticking to legacy spigot mappings standing in the rain. this plugin still relies on those mappings, so you need to fix that and move to mojang mappings or the plugin will break even on spigot for 26.1.
just, spigot in its ignorance doesn't provide you with tools to do this properly, while as I mentioned, we have been for years.
so shifting the blame on paper is really unfair.
Paper has been telling plugin authors for over two years now to move to mojang mappings using the paperweight userdev plugin (https://docs.papermc.io/paper/dev/userdev/), we anticipated mojangs change to unobfuscate the game and prepared our community.
if you need help with implementing paperweight userdev for your plugin, the paper community on discord is happy you with any issues that might come up. thousands of plugins did the move before you, we have seen every issue that might arise.

[LOOHP]

Hey! I'm fully aware that this had been happening for the past years and I'm definately not blaming anyone for anything. It is just the fact that this plugin had not published builds with mojang mappings and hence for it to work reobf mapping needs to be in Paper for the plugin to run. I'm also fully aware of the obfuscation changes that will happen in 26.1. I'll be sure that the plugin is updated accordingly for paper when 26.1 comes along. Thank you for developing papermc :)