Skip to content

[Improvement] General revision of functions, classes and public methods documentation #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 5, 2025

This PR addresses issue #38 by conducting a comprehensive review and improvement of documentation across all functions, classes, and public methods in the asltk package. The review identified and fixed several documentation gaps, typos, and inconsistencies that had accumulated during recent development.

Key Documentation Improvements

Missing Docstrings Added

  • _check_mask_values in aux_methods.py: Added comprehensive documentation explaining validation logic for brain mask processing
  • asl_model_multi_dw in models/signal_dynamic.py: Added detailed docstring with mathematical model description and parameter explanations
  • Helper functions in utils.py: Added docstrings for _check_input_path, _get_file_from_folder_layout, and _make_bids_path

Grammar and Spelling Corrections

  • Fixed multiple grammar errors in ASLData constructor documentation
  • Corrected "tipically" → "typically" and "kernal" → "kernel" in Gaussian smoothing function
  • Fixed "calculations is" → "calculations are" in Buxton model documentation
  • Improved clarity and readability throughout

Parameter Documentation Enhancements

  • Added missing parameter documentation for iterations and converge_min in rigid_body_registration
  • Enhanced parameter descriptions with better explanations of units and expected ranges
  • Improved consistency in parameter formatting across all modules

Examples and Usage Clarification

  • Enhanced existing examples with more detailed explanations
  • Improved documentation of multi-echo and multi-diffusion ASL workflows
  • Better explanation of BIDS structure handling

Quality Assurance

  • All 231 tests continue to pass with 96% coverage
  • Code formatting automatically applied via blue and isort
  • No breaking changes to public APIs
  • Documentation now accurately reflects current implementation

This comprehensive documentation review ensures that all public interfaces are properly documented and that the documentation accurately describes the current implementation, addressing the concerns raised in issue #38 about potential documentation drift during recent development.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@acsenrafilho
Copy link
Member

try again

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: acsenrafilho <9722993+acsenrafilho@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] [Improvement] General revision of functions, classes and public methods documentation [Improvement] General revision of functions, classes and public methods documentation Aug 1, 2025
Copilot finished work on behalf of acsenrafilho August 1, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants