Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default policies from other lightning nodes #14

Conversation

grunch
Copy link
Contributor

@grunch grunch commented Dec 30, 2021

This PR add default policies from the main three implementations
but is not finished yet, there is no default value for some values
like feerate_per_kw_range on three implementations and
max_htlc_value_in_flight_msat_min on lnd, I wrote this on comments

Fix #12

Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out! Can you pls rebase on master, where I fixed CI, so we can run tests (git fetch && git rebase master)?

src/channel/bolt/policy.rs Outdated Show resolved Hide resolved
src/channel/bolt/policy.rs Outdated Show resolved Hide resolved
src/channel/bolt/policy.rs Outdated Show resolved Hide resolved
@grunch grunch force-pushed the issue_12-add-default-policies-from-other-lightning-implementations branch 2 times, most recently from 5a31b28 to 5ae5869 Compare January 3, 2022 17:46
This PR add default policies from the main three implementations

Fix LNP-WG#12
@grunch grunch force-pushed the issue_12-add-default-policies-from-other-lightning-implementations branch from 5ae5869 to 9760b9a Compare January 3, 2022 17:48
Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9760b9a

Thank you very much!

@dr-orlovsky dr-orlovsky merged commit 238abbb into LNP-WG:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default policies from other lightning nodes
2 participants