Adding a migrate method and adding the logic to convert status channels #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce a migrate procedure to be tested, and in addition, this include a json conversion of status channel. It was stored like a map to make the access easy but it works out of the graphql convention. For this reason, the json payload now contains a list of status channel, and the final user need to manage the access to this datastructure. Missing step are: - [ ] Adding metric version in the code, this need to be in the payload to manage the conversion. - [ ] testing the migration options to migrate the actual map of status channels with a list of status channels. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added
enhancement
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
jsarenik
pushed a commit
to jsarenik/go-lnmetrics.reporter
that referenced
this pull request
Nov 29, 2021
Adding a migrate method and adding the logic to convert status channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a migrate procedure to be tested, and in addition, this includes a JSON conversion of the status channel.
It was stored like a map to make the access easy but it works out of the graphql convention. For this reason, the json payload now contains a list of the status channel, and the final user needs to manage the access to this data structure.
Missing steps are:
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com