Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPC frormat about channels in up_time #27

Closed
vincenzopalazzo opened this issue Jul 28, 2021 · 1 comment · Fixed by #28
Closed

Update RPC frormat about channels in up_time #27

vincenzopalazzo opened this issue Jul 28, 2021 · 1 comment · Fixed by #28
Assignees
Labels
format_change Require a change in a JSON format of the payload metric_one Refering to the metric_one of the ln-metrics-rfc refactoring Some idea to make refactoring of the plugin

Comments

@vincenzopalazzo
Copy link
Member

The JSON propriety in the up_time payload about "channels": is unclear. It reports only the number and not the information about the status. I would like to move it on the json object with nodeid and status.

like

{
   "node_id": "0000000",
   "state":  "CHANNELD_AWAITING_LOCKIN",
}
@vincenzopalazzo vincenzopalazzo added format_change Require a change in a JSON format of the payload metric_one Refering to the metric_one of the ln-metrics-rfc refactoring Some idea to make refactoring of the plugin labels Jul 28, 2021
vincenzopalazzo added a commit that referenced this issue Jul 31, 2021
Fixes #27.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo
Copy link
Member Author

The new format is reported below:

{
   "channels_info": {},
   "color": "02bf81",
   "metric_name": "metric_one",
   "node_id": "033904095f082d5fe8ff8d7ee96172e69f166f1b498ccfd3a1e4e5d139d1fad597",
   "os_info": {
      "architecture": "x86_64",
      "os": "Linux Mint",
      "version": "20.1 (Ulyssa)"
   },
   "timezone": "CEST",
   "up_time": [
      {
         "channels": {
            "summary": [],
            "tot_channels": 0
         },
         "event": "on_start",
         "forwards": {
            "completed": 0,
            "failed": 0
         },
         "timestamp": 1627742938
      }
   ]
}

@vincenzopalazzo vincenzopalazzo self-assigned this Jul 31, 2021
jsarenik pushed a commit to jsarenik/go-lnmetrics.reporter that referenced this issue Nov 29, 2021
Fixes LNOpenMetrics#27.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_change Require a change in a JSON format of the payload metric_one Refering to the metric_one of the ln-metrics-rfc refactoring Some idea to make refactoring of the plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant