Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: up_time record #23

Closed
vincenzopalazzo opened this issue Jul 26, 2021 · 0 comments · Fixed by #24
Closed

update: up_time record #23

vincenzopalazzo opened this issue Jul 26, 2021 · 0 comments · Fixed by #24
Assignees
@vincenzopalazzo
Labels
enhancement New feature or request format_change Require a change in a JSON format of the payload metric_one Refering to the metric_one of the ln-metrics-rfc refactoring Some idea to make refactoring of the plugin

Comments

@vincenzopalazzo
Copy link
Member

When the plugin will make a screenshot of the plugin, we are not able to catch if the new payment forwards by the node will fail or not. I would like to move the records "forwards" in an object instance in an accumulator.

From: "forwards": 184,
to:

"forwards": {
   "by_channel": "1x2x3"
   "success": 0,
   "failure": 0,
   "pending": 0,
}

In addition, it will be cool to have also from what channel this payment came, and some information about the payment id
@vincenzopalazzo vincenzopalazzo added enhancement New feature or request refactoring Some idea to make refactoring of the plugin format_change Require a change in a JSON format of the payload metric_one Refering to the metric_one of the ln-metrics-rfc labels Jul 26, 2021
@vincenzopalazzo vincenzopalazzo self-assigned this Jul 26, 2021
vincenzopalazzo added a commit that referenced this issue Jul 26, 2021
@vincenzopalazzo
Fixes #23 and #1.
2718784 
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo mentioned this issue Jul 26, 2021
Merged
vincenzopalazzo added a commit that referenced this issue Jul 26, 2021
@vincenzopalazzo
Fixes #1 and #23
6c0a77a
jsarenik pushed a commit to jsarenik/go-lnmetrics.reporter that referenced this issue Nov 29, 2021
@vincenzopalazzo
Fixes LNOpenMetrics#23 and LNOpenMetrics#1.
e91cd9a 
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
enhancement New feature or request format_change Require a change in a JSON format of the payload metric_one Refering to the metric_one of the ln-metrics-rfc refactoring Some idea to make refactoring of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1 and #23 LNOpenMetrics/go-lnmetrics.reporter
1 participant
@vincenzopalazzo