Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelsInfo as Array is a good choice? #21

Closed
vincenzopalazzo opened this issue Jul 20, 2021 · 0 comments · Fixed by #22
Closed

ChannelsInfo as Array is a good choice? #21

vincenzopalazzo opened this issue Jul 20, 2021 · 0 comments · Fixed by #22
Assignees
@vincenzopalazzo
Labels
refactoring Some idea to make refactoring of the plugin

Comments

@vincenzopalazzo
Copy link
Member

We maintain an array of channels info https://github.com/OpenLNMetrics/go-metrics-reported/blob/0bd0b59c4931c58773019e339516a086870cf967/internal/plugin/metrics_one.go#L81 but this can duplicate some information.

Maybe is better maintains a map of channels (by short channel id) and collect the information inside it?
@vincenzopalazzo vincenzopalazzo added the refactoring Some idea to make refactoring of the plugin label Jul 20, 2021
@vincenzopalazzo vincenzopalazzo self-assigned this Jul 20, 2021
vincenzopalazzo added a commit to LNOpenMetrics/local-reputation-analysis that referenced this issue Jul 20, 2021
@vincenzopalazzo
Start to work on a couple of charts.
28de3fd 
This work found a issue of the JSON format reported in the following issue LNOpenMetrics/go-lnmetrics.reporter#21

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo mentioned this issue Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincenzopalazzo vincenzopalazzo

Labels
refactoring Some idea to make refactoring of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reworking the JSON payload for the channels. LNOpenMetrics/go-lnmetrics.reporter
1 participant
@vincenzopalazzo