Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Received on-chain transaction shows as a sent transaction in the transaction detail modal #539

Closed
mrfelton opened this issue Jul 6, 2018 · 2 comments · Fixed by #3225
Closed

Received on-chain transaction shows as a sent transaction in the transaction detail modal #539

mrfelton opened this issue Jul 6, 2018 · 2 comments · Fixed by #3225
Assignees
@bolatovumar
Labels
type: bug 🐛 Something isn't working
Milestone
v0.7.0-beta

Comments

@mrfelton
Copy link
Member

mrfelton commented Jul 6, 2018

Click on a received on-chain transaction from the transaction list and you see something like this:

screenshot 2018-07-06 18 12 49

In the top left is shows 'Sent', yet tis was an incoming transaction.
@JimmyMow JimmyMow mentioned this issue Jul 7, 2018
Merged
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Jul 13, 2018
@mrfelton
fix(receive-tx): don't show sent for received tx
48681ba 
Fix for LN-Zap#539
@mrfelton mrfelton mentioned this issue Jul 13, 2018
Merged
@steliosrammos
Copy link

The Zap notification on Mac also mentions a send transaction instead of receiving funds.

bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Nov 24, 2019
@bolatovumar
fix(ui): show correct heading for received payment in modal
df0b4bb 
fix LN-Zap#539
@bolatovumar bolatovumar mentioned this issue Nov 24, 2019
Merged
6 tasks
@bolatovumar
Copy link
Contributor

Thanks for the catch @steliosrammos.

@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Nov 25, 2019
@mrfelton mrfelton added this to the v0.6.3-beta milestone Nov 25, 2019
@mrfelton mrfelton modified the milestones: v0.6.3-beta, v0.7.0-beta May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bolatovumar bolatovumar

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.7.0-beta
Development

Successfully merging a pull request may close this issue.

fix(ui): show correct heading for received payment in modal bolatovumar/zap-desktop
3 participants
@mrfelton @bolatovumar @steliosrammos