Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

"Not a valid bitcoin/lightning request." when pasting a valid bitcoin or lightning address into pay form #1510

Closed
mrfelton opened this issue Feb 7, 2019 · 10 comments · Fixed by #1511
Closed

"Not a valid bitcoin/lightning request." when pasting a valid bitcoin or lightning address into pay form #1510

mrfelton opened this issue Feb 7, 2019 · 10 comments · Fixed by #1511
Assignees
@mrfelton
Labels
scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working
Milestone
v0.7.0-beta

Comments

@mrfelton
Copy link
Member

mrfelton commented Feb 7, 2019

Description

Getting the following error when trying to make a payment to a valid onchain or offchain address

image

Expected Behavior

Should detect the address as valid.

Actual Behavior

Shows error "Not a valid bitcoin/lightning request." and does not let me proceed.

Possible Fix

Debug Pay form validation

Steps to Reproduce

Paste valid LN/Bitcoin address into the pay form

Your Environment

  • Zap Desktop version: master
  • Operating System and version: Mac
@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Feb 7, 2019
@mrfelton mrfelton added this to the v0.3.4-beta milestone Feb 7, 2019
@mrfelton mrfelton self-assigned this Feb 7, 2019
mrfelton added a commit to mrfelton/zap-desktop that referenced this issue Feb 7, 2019
@mrfelton
fix(wallet): correctly identify active network
c13ea91 
Due to recent changes in lnd network information (chain/network) can
be located in different parts of the lnd getInfo api call response. We
have already taken some measures to detect and modify this information
so that it is consistent but there were some places in our code where
we were still looking for the info in the old location and as a result
incorrectly identifying the network that a node is running on.

Fix LN-Zap#1510
@mrfelton mrfelton mentioned this issue Feb 7, 2019
Merged
6 tasks
@mrfelton mrfelton added the scope: wallet issues with the wallet interface label Feb 7, 2019
@lieteau2 lieteau2 mentioned this issue Feb 7, 2019
Closed
51 tasks
@btcnym
Copy link

btcnym commented Feb 20, 2020

Tom,
Windows version is doing the same thing. It won't allow me to pay a tippin.me lightning address.
Thanks, I'm running Zap 0.6.2 Beta on Win 10

@robbie2121
Copy link

Tom,
Windows version is doing the same thing. It won't allow me to pay a tippin.me lightning address.
Thanks, I'm running Zap 0.6.2 Beta on Win 10

I'm getting the same message, also trying to tip with tippin.me lightning address. I downloaded the latest zap wallet version for windows 10. (0.6.2-beta)

@bolatovumar
Copy link
Contributor

I can take a deeper look. @oh-kurrrrt @robbie2121 could you provide an example of the toppin.me payment request that fails for you? I can try my own account but in case that doesn't fail and the payment goes through I will need an example of a failing payment request.

@robbie2121
Copy link

I can take a deeper look. @oh-kurrrrt @robbie2121 could you provide an example of the toppin.me payment request that fails for you? I can try my own account but in case that doesn't fail and the payment goes through I will need an example of a failing payment request.

Hi,

This is an example of one that wasn't working: lnbc1p0x2wtwpp5qf36ferg5ereu9nurpud93g4gx7vq5ukaq9jka0ujfuamdxy6x9qdpu235hqurfdcs8xam9v3jhgmmndp5jq2r5d9c8q6tw9ekk22fgw5cnjvfexu5scqzpgxqyz5vqsp5th6wqw0354lnds9nv6hqtdfqueux9vhgxxmsayluanppa7upfg8q9qy9qsqkg2x58ave6jpwl0jvqmgdh5j69f5skzq0najfe3px0umalknkq4rzpcampv47hpt5dkct80qqnnm92xw4ntvq2w0wm3xn8z77qv0ndgqdj6kle

Not sure if these expire, so here is a fresh one:

lnbc1p0xtj6epp5rd0aqa39xft9tfrl048rf5sfpckjzagkhrwcjt05rhpfp8m0hhcsdpu235hqurfdcs8xam9v3jhgmmndp5jq2r5d9c8q6tw9ekk22fgw5cnjvfexu5scqzpgxqyz5vqsp5mwzdutnewqauhun5hm9rfct7gpv0cl8h96a4uzs37kfdgen8ej8s9qy9qsqzp00aqdv96ddunmzqpl4u3c06e7k4akv8q9y49qj93v9d97je7v4k2yad4mxprtzy0njm70sffxmrqumvhnxjy4pmyyuhg3sdhyaangqnvq62v

@mrfelton
Copy link
Member Author

mrfelton commented Mar 9, 2020

Tippin.me produces zero amount invoices - we don’t support paying these in zap because there are security concerns with them.

@bolatovumar
Copy link
Contributor

@mrfelton i'm wondering if we can show a warning to the user saying these are not supported instead of a generic error message?

@mrfelton
Copy link
Member Author

mrfelton commented Mar 9, 2020

Probably a good idea @bolatovumar .

@mrfelton mrfelton reopened this Mar 9, 2020
@robbie2121
Copy link

Tippin.me produces zero amount invoices - we don’t support paying these in zap because there are security concerns with them.

Ah, thank you for letting me know.

@bolatovumar
Copy link
Contributor

@mrfelton ok, i will take a look into doing that.

bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Mar 10, 2020
@bolatovumar
feat(ui): add zero amount payment request message
ac9c736 
address LN-Zap#1510
@bolatovumar bolatovumar mentioned this issue Mar 10, 2020
Merged
6 tasks
bolatovumar added a commit to bolatovumar/zap-desktop that referenced this issue Mar 12, 2020
@bolatovumar
feat(ui): add zero amount payment request message
88e3fe7 
address LN-Zap#1510
mrfelton pushed a commit that referenced this issue Mar 12, 2020
@bolatovumar
fix(ui): add zero amount payment request error (#3385)
6759be0 
address #1510
@mrfelton mrfelton modified the milestones: v0.3.4-beta, v0.7.0-beta May 24, 2020
@mrfelton
Copy link
Member Author

Closing as this is expected behaviour for zero value invoices and we have improved the error message in of #3385

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrfelton mrfelton

Labels
scope: wallet issues with the wallet interface type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.7.0-beta
Development

Successfully merging a pull request may close this issue.

fix(wallet): correctly identify active network mrfelton/zap-desktop
4 participants
@mrfelton @bolatovumar @robbie2121 @btcnym