Make arrow "stepper" buttons themeable and use SVG assets#8123
Merged
messmerd merged 10 commits intoLMMS:masterfrom Nov 21, 2025
Merged
Make arrow "stepper" buttons themeable and use SVG assets#8123messmerd merged 10 commits intoLMMS:masterfrom
messmerd merged 10 commits intoLMMS:masterfrom
Conversation
These buttons are used in the instrument window, Vestige, and VST effects. Separate versions of the arrow icons are used for the classic theme.
rubiefawn
added
enhancement
gui
needs code review
LMMS renders these SVGs just fine, but apparently the removal of the XML declaration completely breaks Github's ability to render the image, so I am adding these back for the sake of those who want to actually look at the diff on the website lmao
You may ask, "what does this have to do with the arrow buttons?" and you would be right to assume this is unrelated. However, I'm already touching the relevant lines of the stylesheet so I may as well sneak it in there.
And fix mixed indentation in headphones.svg
GRADIENTS!!!!!!!!!!!!
The originals were right angle chevrons
rubiefawn
commented
Nov 13, 2025
Member
|
Tested, looks great! |
bratpeki
approved these changes
Nov 20, 2025
Member
|
Please merge ASAP |
Contributor
Author
🤷♀️ |
messmerd
approved these changes
Nov 21, 2025
rubiefawn
removed
the
needs code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades the arrow buttons used in the instrument windows, VST effects, and Vestige from PNG images to CSS utilizing SVG assets for the icons inside.
Before
After
Note
Part of #7767