Ignore "Keep plugin windows on top" setting when on wayland

[AW1534]

Fixes #7896

[AW1534]

@michaelgregorius I was told you may be interested in testing this

[michaelgregorius]

Looks good and fixes the problem for me.

It might be considered to move the functionality to detect if LMMS is running under Wayland in a helper class though in case it is needed in more places.

[AW1534]

thanks for testing. I'm not sure it's worth making a new file just for this though, as it would be a whole new file and/or class just to contain one function which is 1 line long.

[michaelgregorius]

thanks for testing. I'm not sure it's worth making a new file just for this though, as it would be a whole new file and/or class just to contain one function which is 1 line long.

It depends a bit on in how many other places the check

QGuiApplication::platformName().toLower().contains("wayland")

might show up. There is already quite a list of issues related to Wayland: https://github.com/LMMS/lmms/issues?q=is%3Aissue%20state%3Aopen%20wayland

It would also be better for consistency to put it into a shared function/method. One advantage would be that the check above could be changed/adjusted if necessary without having to touch several places in case the raw check above proliferates through the code.

However, it is not the most critical thing for now.

[AW1534]

It depends a bit on in how many other places the check
QGuiApplication::platformName().toLower().contains("wayland")
might show up.

I couldn't find any other matches for platformName().toLower().contains("wayland") or platformName().contains("wayland") in the code

[michaelgregorius]

Thanks for adding the method! Looks good to me now! 👍 I think this can be merged as is.

[AW1534]

Great! Could you please merge?

[michaelgregorius]

Ah, sorry @AW1534, I thought you had merge permissions because you are shown as a member. Will merge...