Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove call to Clip::changeLength #7570

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove call to Clip::changeLength #7570

wants to merge 1 commit into from

Commits on Nov 3, 2024

  1. Remove call to Clip::changeLength 

    Remove the call to `Clip::changeLength` from
`TrackContentWidget::changePosition` as it results in bad performance,
especially when the Song Editor is in auto-scroll mode and the position
is changed very often.

The call in question has set the clip to the length that it already has
which in turn resulted in lots of needless calls to `Song::updateLength`.

It also should not be necessary to update a clip length if all that we
do is change the position of the `TrackContentWidget`.
    @michaelgregorius
    michaelgregorius committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    5626a51 View commit details
    Browse the repository at this point in the history