Smarter fill #7565
Closed
Smarter fill #7565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fill and cut overlaps can be applied twice for further effect - Fill does no longer extend notes that overlap a little
|
I'm breaking this PR into smaller chunks for easier review, starting with #7569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys 🐱
I wanted to keep this PR simple, because I don't want this to end like the last time...
But the PR turned out quite big somehow, so sorry if it's a lot to review.
If you can, just give it a test ride.
Don't fill notes that overlap slightly
Fill removes gaps between notes by extending their endpoints to the next note. But currently if it overlaps the next note, it will be extended until yet another note starts. In this example the last bar should not be filled:
Here's the logic I implemented.
If you don't agree on the percentage, keep in mind that the current code fills if it overlaps more than 0%.
Fill selected notes independently
Imagine you wanted to extend the chords below. Before you couldn't, because they would interfere with the melody. Now you can by pressing Fill twice.
Skarminspelning.2024-10-26.22-09-35.mp4
The popup is only shown if filling a second time would have effect.
Cut overlaps of selected notes
Since I had to redo the Cut overlaps code for this PR, I decided to implement the same feature there. The first cut will be with respect to the selected notes only, the second cut the notes more so they don't overlap any other note (this is the default behavior right now).