Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue processing Song even when no tracks are found #7458

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

sakertooth
Copy link
Contributor

See title. Meant to fix an issue where, given that enough time has passed, exporting a completely empty project attempts to generate an infinitely large file and thus eliminate the available space on the storage device very quickly.

Copy link
Member

@DomClark DomClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we disallowed exporting empty songs anyway, but it turns out this check was removed in #4031. No reason was given, but a use case later emerged in #4629.

The change here looks reasonable, and I don't think the optimisation was particularly useful in the first place.

@sakertooth sakertooth merged commit ff8c470 into LMMS:master Aug 20, 2024
11 checks passed
@sakertooth sakertooth deleted the fix-export-bomb branch August 20, 2024 18:32
sakertooth added a commit to sakertooth/lmms that referenced this pull request Sep 4, 2024
mmeeaallyynn pushed a commit to mmeeaallyynn/lmms that referenced this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants