-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Run LMMS #7427
Draft
JohannesLorenz
wants to merge
10
commits into
LMMS:master
Choose a base branch
from
JohannesLorenz:fix-memleak-help
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
CI: Run LMMS #7427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried everything. CI is just ignoring the |
Looking at the workflow results, it says that there is an error at the bottom. |
Ah, this can be seen only via the Actions tab. Thanks saker! |
JohannesLorenz
force-pushed
the
fix-memleak-help
branch
from
August 10, 2024 12:59
8b66270
to
2574f5f
Compare
Status: I still need to care about proper downloading of the artifacts. |
This runs `lmms --version` and `lmms --help` in the github CI. Further checks, like importing an LMMS project to WAV via CLI, are conceivable.
JohannesLorenz
force-pushed
the
fix-memleak-help
branch
from
September 22, 2024 20:54
eeb80af
to
1786b43
Compare
tresf
reviewed
Oct 2, 2024
This reverts commit d436c7f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
lmms --version
andlmms --help
in the github CI. Further checks, like importing an LMMS project to WAV via CLI, are conceivable.Note: This is a split of #6983 . Mutliple reviews have been done there, but one from DomClark is still outstanding, which I am reworking here.
Edit: CI is finally working, but I still need to rework the comments from review -> Keeping this a draft.