Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug where mono VSTs only output on the left channel #6693

Closed
wants to merge 13 commits into from

Conversation

QuixoticJk
Copy link

@QuixoticJk QuixoticJk commented Apr 20, 2023

Added a check for the amount of input channels and routed a single channel to both out channels if there is only one channel coming in, this should fix the problem of single inputs only getting processed into a single output channel

could still use some testing and might need some reformatting since its my first time using the lmms conventions and im still getting used to it

Fixes #6558

.travis.yml Outdated Show resolved Hide resolved
plugins/VstBase/RemoteVstPlugin.cpp Show resolved Hide resolved
@PhysSong
Copy link
Member

I think this might not be a proper way to fix the issue which you want to fix. Can you provide an example case where this pull request helps?

@messmerd
Copy link
Member

I think this might not be a proper way to fix the issue which you want to fix. Can you provide an example case where this pull request helps?

It looks like this PR is meant to fix #6558.

@luzpaz
Copy link
Contributor

luzpaz commented Jul 2, 2023

@QuixoticJk please respond 👆

@messmerd
Copy link
Member

It seems that @QuixoticJk isn't responding so I will give them another week and then take over this PR.

@zonkmachine
Copy link
Member

Any suggestions for vsts to test this? In #6558 is suggested JuceOPLVSTi but that one won't load for me.

@messmerd
Copy link
Member

I introduced a class called PluginPortConfig in my CLAP plugin PR as a general purpose solution for routing audio in and out of mono plugins. Maybe I should spin it off into its own PR to solve this problem with mono VSTs.

@zonkmachine
Copy link
Member

I introduced a class called PluginPortConfig in my CLAP plugin PR as a general purpose solution for routing audio in and out of mono plugins. Maybe I should spin it off into its own PR to solve this problem with mono VSTs.

Yes. Do you mean merging this and then refactor it later?
PS. I'm still looking for plugins to test this PR/issue.

Copy link
Member

@DomClark DomClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As PhysSong suggests, the changes in this PR are incorrect. This puts what should be two sequential buffers into the left and right channels. The correct behaviour is to process a single buffer, and fill both channels with the same data.

@messmerd
Copy link
Member

messmerd commented May 8, 2024

This PR is superseded by #7247.

@messmerd
Copy link
Member

messmerd commented May 8, 2024

Closing in favor of #7247.

@messmerd messmerd closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono VST plugins output only to the left channel
6 participants