-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the bug where mono VSTs only output on the left channel #6693
Conversation
I think this might not be a proper way to fix the issue which you want to fix. Can you provide an example case where this pull request helps? |
It looks like this PR is meant to fix #6558. |
@QuixoticJk please respond 👆 |
It seems that @QuixoticJk isn't responding so I will give them another week and then take over this PR. |
Any suggestions for vsts to test this? In #6558 is suggested JuceOPLVSTi but that one won't load for me. |
I introduced a class called |
Yes. Do you mean merging this and then refactor it later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As PhysSong suggests, the changes in this PR are incorrect. This puts what should be two sequential buffers into the left and right channels. The correct behaviour is to process a single buffer, and fill both channels with the same data.
This PR is superseded by #7247. |
Closing in favor of #7247. |
Added a check for the amount of input channels and routed a single channel to both out channels if there is only one channel coming in, this should fix the problem of single inputs only getting processed into a single output channel
could still use some testing and might need some reformatting since its my first time using the lmms conventions and im still getting used to it
Fixes #6558