Xpressive plugin fixes #5979

gnudles · 2021-04-10T22:41:44Z

Balanced most of the presets.
Made last function accept floating point input.
Removed "key" and "bnote" for meanwhile.
response for #5868
-- do not merge yet --

Balanced most of the presets. Made last function accept floating point input. Removed "key" and "bnote" for meanwhile

LmmsBot · 2021-04-10T22:52:06Z

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Linux (AppImage): lmms-1.3.0-alpha.1.163%2Bgd623e44fc-linux-x86_64.AppImage (build link)

macOS

macOS : lmms-1.3.0-alpha.1.163%2Bgd623e44fc-mac10.14.dmg (build link)

Windows

Windows 32-bit: lmms-1.3.0-alpha.1.163%2Bgd623e44fc-mingw-win32.exe (build link)
Windows 64-bit: lmms-1.3.0-alpha.1.163%2Bgd623e44fc-mingw-win64.exe (build link)
Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://15417-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.163%2Bgd623e44fc-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15417?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://15418-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.163%2Bgd623e44fc-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15418?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://15415-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.163%2Bgd623e44fc-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15415?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://15416-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.163%2Bgd623e44fc-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15416?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/owdhey516qe734lb/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42066971"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/agmo6hgc67u2q8ui/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42066971"}]}, "commit_sha": "792db61abf8f9a8af08acb367fc9fb0cb16a8331"}

gnudles · 2021-05-11T17:48:29Z

This PR awaits discussion about whether to enable "key" variable in expressions or not.

gnudles · 2021-12-14T20:55:40Z

Before merging, we should upgrade exprtk to the latest version, because expressions such "1 in t" cuases the program to crash...
Latest version seems to accept such formula without crashing.

…g smooth knob when disabled

…es/lmms into xpressive_preset_balancing

…lancing

gnudles · 2021-12-14T22:33:42Z

@PhysSong, do you know why isn't it compiling on windows? I added syntax highlighting in Xpressive plug-in.
Could it be that the following define is true on windows (QT_NO_SYNTAXHIGHLIGHTER)?

,

PhysSong · 2021-12-15T07:46:26Z

Could it be that the following define is true on windows (QT_NO_SYNTAXHIGHLIGHTER)?

It isn't in MSVC builds, but it is in MinGW builds. Looks like @tobydox disabled the feature when building the MinGW PPA.

qnebra · 2021-12-15T15:05:19Z

Well, majority of packages in this PPA needed upgrade. Some get a major additions and bugfixes in upstream versions since they are built in PPA. Additions and fixes which would be really useful for lmms.

gnudles · 2021-12-31T11:17:10Z

Today I read that MSVC++ treat 'long double' the same as double. It is a bit problematic, because the integrate function relies on long double, as it sums frequencies 48000 times, and my tests with plain simple double had distortion after few seconds... any ideas how to overcome this?

PhysSong · 2022-01-01T02:01:05Z

the integrate function relies on long double

I can't find any long doubles in IntegrateFunction. I'd say the round-off error in integration of double is not a concern compared to the precision of float.
You can find some useful resources in #2047.

gnudles · 2022-01-01T18:55:31Z

@PhysSong Yeah, you are right, my bad. somehow my memory convinced me that I was working with 'long double' there, but truth is I used double... saw #2047 and it reminded me my experiments with integrate.
By the way, I added another variable called 'prev' which stores the frequency of the previous note, so now in the formula you can make portamento effect in either the normal way, or any other weird way...
Also, I enabled the feature of variables in the formula, so now you can reuse code by storing numbers in variables, instead of copying code all around the place.
I am considering adding a mechanism to store and get computed values between frames.
One guy on youtube had some suggestions for the plugin which we should consider but I not sure I have the time for this right now (https://www.youtube.com/watch?v=5pJI1JpXNqM&t=25s in comments):

I do have a few suggestions :
Add more wave tables and general-purpose knobs, maybe 32 or up to 256 of each so you practically have limitless control over the sound design.
.....(here comes some feature request that already existed)....
Finally, A UI feature to detach the wave function editor panel to its own window and save/load your functions to a txt file.

added previous frequency to allow portamento effect

PhysSong · 2022-01-06T03:08:37Z

I think your editor is configured to use spaces instead of tabs.

gnudles · 2022-01-06T05:14:16Z

You know, I am really not pressing 4 times on the spacebar when I want to indent, rather I just press the tab bar. I checked QtCreator options and it showed me that it is already set on 'use tab only'. Last commit I detected all these hidden little spaces and replaced every four of them with a tab

Fixed help text error

gnudles · 2022-09-12T21:52:47Z

@tobydox can we drop the QT_NO_SYNTAXHIGHLIGHTER from the qt build? It can really help my plugin to look more welcoming

PhysSong · 2022-09-12T23:59:45Z

@gnudles BTW, could you resolve the conflicts?

tobydox · 2022-09-13T08:33:10Z

@tobydox can we drop the QT_NO_SYNTAXHIGHLIGHTER from the qt build? It can really help my plugin to look more welcoming

Done - also updated to Qt 5.15.6.

gnudles · 2022-10-25T18:41:56Z

@PhysSong yes I should.

update lmms

gnudles · 2023-01-26T21:58:01Z

@PhysSong Tell me if something is wrong.

gnudles · 2023-01-28T21:57:12Z

Why is it failing?

zonkmachine · 2023-01-28T23:45:15Z

Why is it failing?

Quite a few PR's are failing on shellcheck. Probably not on your side.
@PhysSong knows more.

PhysSong · 2023-01-28T23:46:21Z

Yes, you can ignore this.
If you're still concerned, you can merge the latest master to your branch.

Merge lmms master

Xpressive plugin -

b2c6512

Balanced most of the presets. Made last function accept floating point input. Removed "key" and "bnote" for meanwhile

gnudles changed the title ~~Xpressive plugin -~~ Xpressive plugin fixes- Apr 10, 2021

gnudles changed the title ~~Xpressive plugin fixes-~~ Xpressive plugin fixes Apr 11, 2021

he29-net mentioned this pull request Apr 18, 2021

MIDI range MKII (extracted from microtonal PR) #5868

Merged

Merge branch 'master' into xpressive_preset_balancing

791fd20

gnudles added 4 commits December 14, 2021 23:17

Moved to QTextEdit, in order to enable syntax highlighting. fix hidin…

ddca83f

…g smooth knob when disabled

Merge branch 'xpressive_preset_balancing' of https://github.com/gnudl…

a4efe04

…es/lmms into xpressive_preset_balancing

Merge remote-tracking branch 'origin/master' into xpressive_preset_ba…

3f44576

…lancing

Disable syntax highlight if it is not available.

400b07a

added Kick by khoidauminh

792db61

added previous frequency to allow portamento effect

Update Xpressive.cpp

404ef04

Fixed help text error

gnudles added 4 commits January 26, 2023 21:44

Xpressive plugin - added envelope, last note played for glitch.

fb8c41f

Added Kick by khoidauminh

eb1498e

Merge pull request #1 from LMMS/master

4a67842

update lmms

Merge branch 'master' into xpressive_preset_balancing

4e868d1

close ifdef with comment

cb3d3d8

Merge pull request #2 from LMMS/master

142a522

Merge lmms master

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Xpressive plugin fixes #5979

Xpressive plugin fixes #5979

gnudles commented Apr 10, 2021 •

edited

Loading

LmmsBot commented Apr 10, 2021 •

edited

Loading

Linux

macOS

Windows

gnudles commented May 11, 2021

gnudles commented Dec 14, 2021

gnudles commented Dec 14, 2021

PhysSong commented Dec 15, 2021

qnebra commented Dec 15, 2021

gnudles commented Dec 31, 2021 •

edited

Loading

PhysSong commented Jan 1, 2022

gnudles commented Jan 1, 2022 •

edited

Loading

PhysSong commented Jan 6, 2022

gnudles commented Jan 6, 2022 •

edited

Loading

gnudles commented Sep 12, 2022

PhysSong commented Sep 12, 2022

tobydox commented Sep 13, 2022

gnudles commented Oct 25, 2022

gnudles commented Jan 26, 2023

gnudles commented Jan 28, 2023

zonkmachine commented Jan 28, 2023

PhysSong commented Jan 28, 2023

Xpressive plugin fixes #5979

Are you sure you want to change the base?

Xpressive plugin fixes #5979

Conversation

gnudles commented Apr 10, 2021 • edited Loading

LmmsBot commented Apr 10, 2021 • edited Loading

Linux

macOS

Windows

gnudles commented May 11, 2021

gnudles commented Dec 14, 2021

gnudles commented Dec 14, 2021

PhysSong commented Dec 15, 2021

qnebra commented Dec 15, 2021

gnudles commented Dec 31, 2021 • edited Loading

PhysSong commented Jan 1, 2022

gnudles commented Jan 1, 2022 • edited Loading

PhysSong commented Jan 6, 2022

gnudles commented Jan 6, 2022 • edited Loading

gnudles commented Sep 12, 2022

PhysSong commented Sep 12, 2022

tobydox commented Sep 13, 2022

gnudles commented Oct 25, 2022

gnudles commented Jan 26, 2023

gnudles commented Jan 28, 2023

zonkmachine commented Jan 28, 2023

PhysSong commented Jan 28, 2023

gnudles commented Apr 10, 2021 •

edited

Loading

LmmsBot commented Apr 10, 2021 •

edited

Loading

gnudles commented Dec 31, 2021 •

edited

Loading

gnudles commented Jan 1, 2022 •

edited

Loading

gnudles commented Jan 6, 2022 •

edited

Loading