Enhanced quantize in PianoRoll #5946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
Linux
macOS🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://13050-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg03e9a7d40-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13050?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://13049-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg03e9a7d40-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13049?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/oaclcleb8k6b6i8j/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38252221"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/m4eld9bqaq8arsh6/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/38252221"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://13047-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg03e9a7d-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13047?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://13046-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.85%2Bg03e9a7d40-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/13046?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "98c2fcd6194118e9723f4f3973a466fe1dffde8e"} |
|
Thanks for splitting this out. As a heads up to anyone else seeing this, the original PR is from before the PR freeze. |
IanCaio
approved these changes
Mar 14, 2021
|
I just realized something: Could you update the Classic theme CSS Stylesheet as well? |
Spekular
approved these changes
Mar 16, 2021
|
As Ian points out, this probably needs an update for the Classic theme stylesheet as well. After that I'd like to merge it :) |
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
* Button with menu has split highlight * Add menu with more action to quantize button * Style changes * Fix CSS length-zero-no-unit warning * Add combo button to classic theme
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
* Button with menu has split highlight * Add menu with more action to quantize button * Style changes * Fix CSS length-zero-no-unit warning * Add combo button to classic theme
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Button with menu has split highlight * Add menu with more action to quantize button * Style changes * Fix CSS length-zero-no-unit warning * Add combo button to classic theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry picked from #5702.
Styling bug?
I can't get styling of combined button/dropdown to work as I want. Maybe it's impossible to get the way I want, since the arrow is a subcontrol if the button. Qt CSS experts will understand. This is how styling of buttons with a menu arrow behaves currently:
hoverhoverpressedpressedhoverpressed(!!!)pressedpressedMy solution is to let the arrow have the same style, no matter hover or press. This way it stands of from the main button when hovering it, but the weird behavior is not displayed.