Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved relative paths #5117

Merged
merged 44 commits into from
Jul 28, 2020
Merged

Improved relative paths #5117

merged 44 commits into from
Jul 28, 2020

Commits on Aug 5, 2019

  1. Create PathUtils

    @Spekular
    Spekular committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    cd15286 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Replace old SampleBuffer calls

    @Spekular
    Spekular committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    decd9a9 View commit details
    Browse the repository at this point in the history

  2. Fix automatic track names

    @Spekular
    Spekular committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    51328b0 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. Fix things

    @Spekular
    Spekular committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    a2dc1dd View commit details
    Browse the repository at this point in the history

  2. Remove accidental duplicate file

    @Spekular
    Spekular committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    7a193ac View commit details
    Browse the repository at this point in the history

  3. Add includes

    @Spekular
    Spekular committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    b9951a9 View commit details
    Browse the repository at this point in the history

  4. More incldues

    @Spekular
    Spekular committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    7a1bc2f View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2019

  1. PhysSong's code review + style

    @Spekular
    Spekular committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    316b7b7 View commit details
    Browse the repository at this point in the history

  2. Fix vestige loading? 

    Seems more reasonable to convert from relative on load and to relative on save than vice versa.
    @Spekular
    Spekular authored Aug 11, 2019
    Configuration menu
    Copy the full SHA
    5baff4c View commit details
    Browse the repository at this point in the history

  3. Typo fix

    @Spekular
    Spekular authored Aug 11, 2019
    Configuration menu
    Copy the full SHA
    332b422 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. More Bases

    @Spekular
    Spekular authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    009ea38 View commit details
    Browse the repository at this point in the history

  2. Enable more bases

    @Spekular
    Spekular authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    133cd13 View commit details
    Browse the repository at this point in the history

  3. Add missing semicolons in prefixes

    @Spekular
    Spekular authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    334a90a View commit details
    Browse the repository at this point in the history

  4. Nicer sample track tooltip

    @Spekular
    Spekular committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    a001977 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. Use correct directories 

    "userXDir" gives the default dir for ladspa, sf2, and gig. "xDir" gives the user dir.
    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    bcdecc2 View commit details
    Browse the repository at this point in the history

  2. Make relative to both default and custom locations 

    Part 1
    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    d3ccf3c View commit details
    Browse the repository at this point in the history

  3. Make relative to both default and custom locations 

    Part 2
    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    39c1dc1 View commit details
    Browse the repository at this point in the history

  4. Typofix

    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    0ac89bf View commit details
    Browse the repository at this point in the history

  5. Typofix

    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    7dc359d View commit details
    Browse the repository at this point in the history

  6. Fix upgrade function after base renaming

    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    bf24a9b View commit details
    Browse the repository at this point in the history

  7. Fix Tests

    @Spekular
    Spekular authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    8f9dc7a View commit details
    Browse the repository at this point in the history

  8. Update tests/src/core/RelativePathsTest.cpp 

    Co-Authored-By: Hyunjin Song <tteu.ingog@gmail.com>
    @Spekular @PhysSong
    Spekular and PhysSong authored Aug 18, 2019
    Configuration menu
    Copy the full SHA
    1147abf View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2019

  1. Choose UserXBase over DefaultXBase if identical 

    toShortestRelative sticks with the first base found if two bases give the same path length. By placing UserXBase Bases before DefaultXBase Bases in the relativeBases vector, toShortestRelative will prioritize them.
    @Spekular
    Spekular authored Aug 19, 2019
    Configuration menu
    Copy the full SHA
    34c6fc2 View commit details
    Browse the repository at this point in the history

  2. Ensure baseLocation always has trailing slash 

    Otherwise, a user configuring a path without one will break things.
    @Spekular
    Spekular authored Aug 19, 2019
    Configuration menu
    Copy the full SHA
    c0ac743 View commit details
    Browse the repository at this point in the history

  3. Move loc declaration out of switch

    @Spekular
    Spekular authored Aug 19, 2019
    Configuration menu
    Copy the full SHA
    de4fc5f View commit details
    Browse the repository at this point in the history

  4. Semicolon

    @Spekular
    Spekular authored Aug 19, 2019
    Configuration menu
    Copy the full SHA
    3cebac8 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review...

    @Spekular
    Spekular authored Aug 19, 2019
    Configuration menu
    Copy the full SHA
    97a35a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Include PathUtil and sort includes

    @Spekular
    Spekular authored Aug 23, 2019
    Configuration menu
    Copy the full SHA
    ca0e46d View commit details
    Browse the repository at this point in the history

  2. More granular includes

    @Spekular
    Spekular authored Aug 23, 2019
    Configuration menu
    Copy the full SHA
    455452e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Hyunjin Song <tteu.ingog@gmail.com>
    @Spekular @PhysSong
    Spekular and PhysSong authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    fa78dc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Update include/PathUtil.h

    @Spekular
    Spekular authored Nov 7, 2019
    Configuration menu
    Copy the full SHA
    b7c038e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. Leave empty paths alone

    @Spekular
    Spekular committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    9f386cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'qdir' of https://github.com/Spekular/lmms into qdir

    @Spekular
    Spekular committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    6853aec View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Merge with master

    @Spekular
    Spekular committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3dbcfae View commit details
    Browse the repository at this point in the history

  2. Fix stupid merge

    @Spekular
    Spekular committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    436c993 View commit details
    Browse the repository at this point in the history

  3. Really fix merge. Hopefully

    @Spekular
    Spekular committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8b73a4c View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. Switch Base from enum to class enum

    @Spekular
    Spekular committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    9295500 View commit details
    Browse the repository at this point in the history

  2. Don't pass Base by reference

    @Spekular
    Spekular committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    d4b3318 View commit details
    Browse the repository at this point in the history

  3. Use QStringLiteral for static QString allocation in basePrefix method

    @Spekular
    Spekular committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    0bd5e5e View commit details
    Browse the repository at this point in the history

  4. Make VST loading more similar to previous implementation

    @Spekular
    Spekular committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    f3773d8 View commit details
    Browse the repository at this point in the history

  5. Fix tests after enum change

    @Spekular
    Spekular committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    4d8818c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2020

  1. Attempt to fix VST loading, nicer name for sample clips

    @Spekular
    Spekular committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    70221d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Fix last review comment 

    Don't append a "/" that will be removed by cleanPath later
    @Spekular
    Spekular authored Jul 21, 2020
    Configuration menu
    Copy the full SHA
    e55e34c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
    @Spekular @DomClark
    Spekular and DomClark authored Jul 27, 2020
    Configuration menu
    Copy the full SHA
    4274c22 View commit details
    Browse the repository at this point in the history