Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #4771

Merged
merged 4 commits into from
Jan 19, 2019
Merged

Small fixes #4771

merged 4 commits into from
Jan 19, 2019

Conversation

DomClark
Copy link
Member

@DomClark DomClark commented Jan 14, 2019 •
edited
Loading

24f3387 addresses part of #4730.
676feb5 links RemoteZynAddSubFx with -mwindows on Windows, which is what we do with RemoteVstPlugin since 0ad8527.
30e44b7 fixes #3677.
e60e1d2 fixes #4755.

@zonkmachine
Copy link
Member

24f3387 and 30e44b7 I would merge straight away but the CMake stuff is hopelessly beyond me.

@zonkmachine
Copy link
Member

Merge?

@DomClark
Copy link
Member Author

I thought I might tack a fix for #4755 on here, since it's small, easy, and milestoned for 1.2

@zonkmachine
Copy link
Member

if(atoms) { ...

Commit. Push. Merge... 🚀

@DomClark
Copy link
Member Author

Waiting for CI. Will merge once it passes.

@DomClark DomClark merged commit 1faaf00 into LMMS:stable-1.2 Jan 19, 2019
@DomClark DomClark deleted the miscfixes2019-01 branch March 12, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memcpy on a null pointer Some problems with VST. Again.
2 participants
@DomClark @zonkmachine