Don't try to clear null buffer in NotePlayHandle::play #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for rare crashes when changing tempo while playing notes with stacking and/or arpeggio. When playing the master note, _working_buffer is null. Tempo change causes false positive in the check because NotePlayHandle::resize changes m_totalFramesPlayed. Thanks to 6fc4577, we can safely drop the memset call.
Downloads for this pull requestsGenerated by a bot. Sorry. :P |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This is a workaround for rare crashes when changing the tempo while playing notes with stacking and/or arpeggio. When playing the master note, _working_buffer is null. Tempo change causes false positive in the check because NotePlayHandle::resize changes m_totalFramesPlayed. Thanks to 05c2c53, we can safely drop the memset call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for rare crashes when changing tempo while playing notes with stacking and/or arpeggio.
When playing the master note,
_working_bufferis null. Tempo change causes false positive in the check becauseNotePlayHandle::resizechangesm_totalFramesPlayed.Thanks to 6fc4577, we can safely drop the memset call.
Fixes #4537.