Disable fluidsynth audio backends if possible #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, for what it's worth. That same runtime check worked for me. with that, my plugin was able to use standard fluidsynth without compile flags. |
|
Tested, works. Travis is happy. Merging. |
|
The version check will silently evaluate to false for a 2.0 or 1.2.0 release. Consider using #if FLUIDSYNTH_VERSION_MAJOR > 1 || FLUIDSYNTH_VERSION_MICRO > 1 || (FLUIDSYNTH_VERSION_MICRO >= 1 && FLUIDSYNTH_VERSION_MICRO >= 9)
or #if QT_VERSION_CHECK(FLUIDSYNTH_VERSION_MAJOR, FLUIDSYNTH_VERSION_MINOR, FLUIDSYNTH_VERSION_MICRO) >= QT_VERSION_CHECK(1,1,9)
|
|
@derselbst good catch. Done via aaee2ec. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Per LMMS#4300 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649
Partially reverts #3446
Wiki has already been updated to remove custom homebrew formulae.
https://github.com/LMMS/lmms/wiki/Dependencies-MacOS