added the function randsv to Xpressive

[gnudles]

that function let you choose the random seed thus allowing persistent vector upon note plays and upon waveforms transit in the gui.

[tresf]

Before merging this, @ArashPartow can you help us decide which commit to use for our submodule? We can no longer find ArashPartow/exprtk@aad301a.

[tresf]

@ArashPartow thanks kindly for chiming in with a reply. This is probably a better place than #4077 for this discussion so I'll paste my reply here again.

In our build system, we could coerce this, but no, git submodules do not directly permit this. Is there a particular reason why the history was erased? This is generally uncommon for a master branch and it also leaves a bit of ambiguity as to what occurred for a particular update.

Worse, it takes reliable builds completely out of our hands as we wouldn't know if a breaking change existed until after our build system broke. It's not something I would encourage or want.

For now, our code pulls from my fork which has the history restored . This fork is only around until we understand if there's a viable and reliable way to use a submodule against upstream. 👍

[tresf]

@gnudles now that Travis is fixed there seem to be some code fixes in store, here's one of the errors from Travis-CI:

In file included from /home/travis/build/LMMS/lmms/plugins/Xpressive/Xpressive.h:38:0,
                 from /home/travis/build/LMMS/lmms/plugins/Xpressive/Xpressive.cpp:25:
/home/travis/build/LMMS/lmms/plugins/Xpressive/ExprSynth.h:56:45: error: ‘numeric_limits’ was not declared in this scope

[tresf]

@ArashPartow done and done. @gnudles sorry, had to fast-forward your branch, you'll have to wind it back a few commits git reset --hard HEAD~3 and then git pull.

[tresf]

Build still failing due to numeric_limits. I'll defer to @gnudles I'd rather leave the coding to him, I'm better off sticking to the build environment. :)

/home/travis/build/LMMS/lmms/plugins/Xpressive/ExprSynth.h:57:45: note: suggested alternative:
In file included from /home/travis/build/LMMS/lmms/plugins/Xpressive/ExprSynth.h:30:0,
                 from /home/travis/build/LMMS/lmms/plugins/Xpressive/ExprSynth.cpp:26:
/opt/mingw32/i686-w64-mingw32/include/c++/4.9.4/limits:304:12: note:   'std::numeric_limits'
     struct numeric_limits : public __numeric_limits_base
            ^
In file included from /home/travis/build/LMMS/lmms/plugins/Xpressive/ExprSynth.cpp:26:0:
/home/travis/build/LMMS/lmms/plugins/Xpressive/ExprSynth.h:57:60: error: expected primary-expression before 'float'
  static const int max_float_integer_mod=(1<<numeric_limits<float>::digi

[gnudles]

@tresf , I hope I didn't messed things up too much, I recreated the fixed commit on the top of lmms:master. I added "std::" before numeric_limits.

[gnudles]

BTW, did you know you can use this plugin to play non-western music?
you can set the difference between the keys to be quarter tone like this:
sinew(integrate(440cent(50(key-bnote))))

[tresf]

@gnudles is this ready to merge?

[gnudles]

It looks OK to me, but I didn't tested it yet cause I somewhat can't compile lmms anymore after upgrading ubuntu. it keeps complain on missing XCB in cmake...

[PhysSong]

it keeps complain on missing XCB in cmake...

Can you try git submodule update --init --recursive? Alternatively, you may install extra-cmake-modules instead.

[tresf]

@gnudles I think you need:

sudo apt-get install qtbase5-private-dev libxcb-util0-dev libxcb-keysyms1-dev

Per https://github.com/LMMS/lmms/wiki/dependencies-ubuntu#qt5

[gnudles]

thanks, now it works. BTW I also get that message:
Fetched in submodule path 'plugins/LadspaEffect/calf/veal', but it did not contain 816b4d2b7cc20429faf96863d7e8ba1cda48ace8. Direct fetching of that commit failed.
so it looks like that commit has been deleted

[tresf]

Direct fetching of that commit failed.

Interesting. If it compiles, ignore it. It probably got confused when we renamed the branch from veal/ladspa to veal/ladspa-0.18 in preparation for #3987.

[gnudles]

It looks sane, I think you can merge.