Disable portaudio on Windows #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless there are objections, I'll merge this in 24 hours. |
|
It's easy enough to revert in case there are any objections. 👍 |
PhysSong
reviewed
Oct 18, 2017
| SET(WANT_SOUNDIO OFF) | ||
| SET(WANT_WINMM ON) | ||
| SET(LMMS_HAVE_WINMM TRUE) | ||
| SET(STATUS_ALSA "<not supported on this platform>") | ||
| SET(STATUS_JACK "<not supported on this platform>") | ||
| SET(STATUS_PULSEAUDIO "<not supported on this platform>") | ||
| SET(STATUS_PORTAUDIO "<disabled on this platform") |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Disable portaudio on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#512 Has been happening for more and more users lately, we have people who can't even open the software on their machines. I provided them with a build with portaudio removed and their issues were gone.
Portaudio was always hard to set up on windows for me, and I find SDL works every time. If WASAPI support is required, I think we should focus on libsoundio, even though that would mean dropping support for windows XP. ASIO is also a planned feature for libsoundio: andrewrk/libsoundio#23
Anyways, in conclusion, Portaudio causes more problems than benfits on windows, and I think it should be disabled.