Fixed inverted zooming. #3570
Merged
Fixed inverted zooming. #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapashcanon
reviewed
May 22, 2017
src/gui/editors/AutomationEditor.cpp
Outdated
| @@ -1627,11 +1627,11 @@ void AutomationEditor::wheelEvent(QWheelEvent * we ) | |||
| int x = m_zoomingXModel.value(); | |||
| if( we->delta() > 0 ) | |||
| { | |||
| x--; | |||
| x++; | |||
| } | |||
| if( we->delta() < 0 ) | |||
There was a problem hiding this comment.
else if( we->delta() < 0 )Will prevent one useless test when x > 0. I know it's not directly related to this PR, but spotted this so...
zapashcanon
reviewed
May 22, 2017
src/gui/editors/PianoRoll.cpp
Outdated
| } | ||
| if( we->delta() < 0 ) | ||
| { | ||
| z++; | ||
| z--; |
zapashcanon
reviewed
May 22, 2017
src/gui/editors/SongEditor.cpp
Outdated
| } | ||
| if( we->delta() < 0 ) | ||
| { | ||
| z++; | ||
| z--; |
|
Tested locally, lmms not crashing yet. LMB zoom in, RMB zoom out both on pianoroll and automation editor, and song editor too. |
zonkmachine
approved these changes
Jun 8, 2017
There was a problem hiding this comment.
I seem to be the only one bothered by the opposite action of the mouse wheel scrolling when zooming in the editor versus scrolling over the combo box. I'm happy to revert back to the original behaviour since the majority seem to be in favour of it. Code looks fine.
|
Merge? |
Umcaruje
approved these changes
Jun 10, 2017
tresf
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 12, 2017
* Fixed inverted zooming. * Prevent useless tests.
|
Cherry-picked and ready for master via 2652005. |
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
* Fixed inverted zooming. * Prevent useless tests.
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
* Fixed inverted zooming. * Prevent useless tests.
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Fixed inverted zooming. * Prevent useless tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3568.