Fix importing MIDI file from command line #3287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not look right. If the model is inconsistent, then the fix should be in the model rather than in a GUI object. |
zonkmachine
force-pushed
the
midiimport
branch
from
32a09c3
to
480d76c
Compare
Right. Should this be done in the MidiImport.cpp instead? I just noticed that we also don't set the tempo for the project and |
|
I'm more off than I thought with this. I'll close this for now since there is development going on with the drumstick branch. Interestingly that branch sees the precise same issues. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2562
Call
Engine::updateFramesPerTick()as suggested by @michaelgregorius