-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP3 stereo mode doesn't match to the selection in export dialog #5876
Comments
@PhysSong is this the expected changes need to be updated? please let me know. will push the changes. OutputSettings::StereoMode mapToStereoMode(int index) |
@deenadayalancs You're right. |
@PhysSong Please assign this to me. I am not able to merge and update the code. Not able to create a pull request by myself. Please create a pull request and assign this to me. will push the changes. Thanks again. |
You have already made a PR earlier. What's the problem this time? |
@zonkmachine thanks for the details. I tried to edit from my desktop client. guess, something is missing there. updated and merged the code. Have a nice day. |
Fixed in #5890. |
#3826 reordered the stereo mode selections in the export dialog, but it didn't update
mapToStereoMode
function inExportProjectDialog.cpp
. The order should now be changed to mono, stereo, joint stereo.lmms/src/gui/ExportProjectDialog.cpp
Lines 140 to 153 in 24761a4
The text was updated successfully, but these errors were encountered: