Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3 stereo mode doesn't match to the selection in export dialog #5876

Closed
PhysSong opened this issue Jan 6, 2021 · 6 comments
Closed

MP3 stereo mode doesn't match to the selection in export dialog #5876

PhysSong opened this issue Jan 6, 2021 · 6 comments
Assignees
Labels
bug development branch This issue affects the development branch(master) good first issue
Milestone

Comments

@PhysSong
Copy link
Member

PhysSong commented Jan 6, 2021

#3826 reordered the stereo mode selections in the export dialog, but it didn't update mapToStereoMode function in ExportProjectDialog.cpp. The order should now be changed to mono, stereo, joint stereo.

OutputSettings::StereoMode mapToStereoMode(int index)
{
switch (index)
{
case 0:
return OutputSettings::StereoMode_Stereo;
case 1:
return OutputSettings::StereoMode_JointStereo;
case 2:
return OutputSettings::StereoMode_Mono;
default:
return OutputSettings::StereoMode_Stereo;
}
}

@PhysSong PhysSong added bug good first issue development branch This issue affects the development branch(master) labels Jan 6, 2021
@DomClark DomClark added this to the 1.3 milestone Jan 13, 2021
@deenadayalancs
Copy link
Contributor

@PhysSong is this the expected changes need to be updated? please let me know. will push the changes.

OutputSettings::StereoMode mapToStereoMode(int index)
{
switch (index)
{
case 0:
return OutputSettings::StereoMode_Mono;
case 1:
return OutputSettings::StereoMode_Stereo;
case 2:
return OutputSettings::StereoMode_JointStereo;
default:
return OutputSettings::StereoMode_Stereo;
}
}

@PhysSong
Copy link
Member Author

@deenadayalancs You're right.

@deenadayalancs
Copy link
Contributor

deenadayalancs commented Jan 21, 2021

@PhysSong Please assign this to me. I am not able to merge and update the code. Not able to create a pull request by myself.

Please create a pull request and assign this to me. will push the changes. Thanks again.

@zonkmachine
Copy link
Member

I am not able to merge and update the code. Not able to create a pull request by myself.

You have already made a PR earlier. What's the problem this time?
The developers are active on Discord https://discord.com/invite/3sc5su7
I suggest you use the channel #dev-support for help with PR's.

deenadayalancs added a commit to deenadayalancs/lmms that referenced this issue Jan 21, 2021
Fix for MP3 stereo mode doesn't match to the selection in export dialog LMMS#5876

Updated the code to match the LMMS#5876.
@deenadayalancs
Copy link
Contributor

@zonkmachine thanks for the details. I tried to edit from my desktop client. guess, something is missing there. updated and merged the code.

Have a nice day.

@DomClark
Copy link
Member

Fixed in #5890.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug development branch This issue affects the development branch(master) good first issue
Projects
None yet
Development

No branches or pull requests

4 participants